Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: update suit-generator sha #19822

Conversation

robertstypa
Copy link
Contributor

Improve exception handling when parsing corrupted CBOR inputs

Signed-off-by: Robert Stypa [email protected]

@robertstypa robertstypa requested review from kszromek-nordic and a team January 9, 2025 14:04
@robertstypa robertstypa requested a review from a team as a code owner January 9, 2025 14:04
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 9, 2025
@robertstypa robertstypa added this to the 2.9.0-nRF54H20 milestone Jan 9, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@f07d308 nrfconnect/suit-generator@c0a59a8 (v2.9-nRF54H20-branch) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: c3a905f9415e23e3f02ad4fdba8ec76a9ce3f654
suit-generator: PR head: c0a59a898d0f8ce96937fa5adf4ffa4bb344a837

more details

sdk-nrf:

PR head: c3a905f9415e23e3f02ad4fdba8ec76a9ce3f654
merge base: 9299b43e0891eb3d300f6139d1b8235f95ed8832
target head (main): 7084bd619b16e9e2f2f0381848102fe0b6d59b41
Diff

suit-generator:

PR head: c0a59a898d0f8ce96937fa5adf4ffa4bb344a837
merge base: 3925944964857d2c690468ecd5f4ae99b03fe19b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (48)
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── .github
│  │  │  │  ├── workflows
│  │  │  │  │  │ static_analysis.yml
│  │  │  ├── .gitignore
│  │  │  ├── build_configuration
│  │  │  │  ├── __init__.py
│  │  │  │  │ configuration.py
│  │  │  ├── examples
│  │  │  │  ├── input_files
│  │  │  │  │  │ envelope_2_hierarchical.yaml
│  │  │  ├── ncs
│  │  │  │  ├── 802154_rad_envelope.yaml.jinja2
│  │  │  │  ├── Kconfig
│  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  ├── app_envelope_encrypted.yaml.jinja2
│  │  │  │  ├── basic_kms.py
│  │  │  │  ├── build.py
│  │  │  │  ├── encrypt_script.py
│  │  │  │  ├── multiprotocol_rad_envelope.yaml.jinja2
│  │  │  │  ├── nordic_top_envelope.yaml.jinja2
│  │  │  │  ├── rad_envelope.yaml.jinja2
│  │  │  │  ├── root_with_nordic_top_envelope.yaml.jinja2
│  │  │  │  ├── secdom_update_envelope.yaml.jinja2
│  │  │  │  ├── sign_script.py
│  │  │  │  │ sysctrl_envelope.yaml.jinja2
│  │  │  ├── pyproject.toml
│  │  │  ├── suit_generator
│  │  │  │  ├── __init__.py
│  │  │  │  ├── args.py
│  │  │  │  ├── cli.py
│  │  │  │  ├── cmd_cache_create.py
│  │  │  │  ├── cmd_convert.py
│  │  │  │  ├── cmd_image.py
│  │  │  │  ├── cmd_mpi.py
│  │  │  │  ├── cmd_payload_extract.py
│  │  │  │  ├── logger.py
│  │  │  │  ├── logging.yaml
│  │  │  │  ├── suit
│  │  │  │  │  ├── envelope.py
│  │  │  │  │  ├── manifest.py
│  │  │  │  │  ├── security.py
│  │  │  │  │  ├── types
│  │  │  │  │  │  ├── common.py
│  │  │  │  │  │  │ keys.py
│  │  │  │  │ suit_kms_base.py
│  │  │  ├── tests
│  │  │  │  ├── test_args.py
│  │  │  │  ├── test_cli.py
│  │  │  │  ├── test_cmd_cache_create.py
│  │  │  │  ├── test_cmd_image.py
│  │  │  │  ├── test_envelope.py
│  │  │  │  ├── test_envelope_api.py
│  │  │  │  ├── test_ncs_sign_script.py
│  │  │  │  ├── test_suit_authentication.py
│  │  │  │  ├── test_suit_encryption.py
│  │  │  │  ├── test_suit_envelope.py
│  │  │  │  │ test_suit_envelope_severable.py
west.yml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@robertstypa robertstypa force-pushed the fix/suit_generator_exception_handling branch from 2de3ce1 to 4b850f1 Compare January 9, 2025 14:37
Improve exception handling when parsing corrupted CBOR inputs

Signed-off-by: Robert Stypa <[email protected]>
@robertstypa robertstypa force-pushed the fix/suit_generator_exception_handling branch from 4b850f1 to c3a905f Compare January 9, 2025 14:42
@@ -242,7 +242,7 @@ manifest:
upstream-sha: c6eaeda5a1c1c5dbb24dce7e027340cb8893a77b
compare-by-default: false
- name: suit-generator
revision: f07d308f03e039bc73767c145f4cff4a70e74442
revision: c0a59a898d0f8ce96937fa5adf4ffa4bb344a837
Copy link
Contributor

@anangl anangl Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this point to nrfconnect/suit-generator@7cde03f, the commit from main? This PR targets main, not v2.9-nRF54H20-branch.

@robertstypa robertstypa changed the base branch from main to v2.9-nRF54H20-branch January 10, 2025 07:29
@robertstypa robertstypa changed the base branch from v2.9-nRF54H20-branch to main January 10, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.9-nRF54H20-branch changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-suit-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants