suit: nRF9280 SUIT support #18496

mparpala · 2024-11-04T10:30:46Z

Add SUIT support for nRF9280 EngB product.

CLAassistant · 2024-11-04T10:30:52Z

All committers have signed the CLA.

NordicBuilder · 2024-11-04T10:32:35Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 48

Inputs:

Sources:

sdk-nrf: PR head: d7b37b4a890d4822ba067a46ead354ab34f741ab

more details

sdk-nrf:

PR head: d7b37b4a890d4822ba067a46ead354ab34f741ab
merge base: 30bd02b2229f9836f5eca6dd02ea273f110f6514
target head (main): 197a1089440d887ad2347457dc678877e1d46e18
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (25)

cmake
│  ├── sysbuild
│  │  ├── suit.cmake
│  │  ├── suit_provisioning.cmake
│  │  │ suit_provisioning_nrf9280.cmake
config
│  ├── suit
│  │  ├── templates
│  │  │  ├── nrf9280
│  │  │  │  ├── default
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_envelope_app_local.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_envelope_direct.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_local_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_recovery_envelope.yaml.jinja2
│  │  │  │  │  │  │ root_with_binary_nordic_top.yaml.jinja2
subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  ├── cracen
│  │  │  │  │  │ Kconfig
│  ├── suit
│  │  ├── mci
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  │ suit_mci_nrf9280.c
│  │  ├── memory_layout
│  │  │  │ Kconfig
│  │  ├── metadata
│  │  │  ├── include
│  │  │  │  │ suit_metadata.h
│  │  ├── platform
│  │  │  ├── Kconfig
│  │  │  ├── sdfw
│  │  │  │  ├── src
│  │  │  │  │  │ suit_plat_check_image_match_sdfw_specific.c
│  │  ├── storage
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  │ suit_storage_nrf9280.c
│  │  ├── stream
│  │  │  │ Kconfig
│  │  ├── validator
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  │ suit_validator_nrf9280.c
sysbuild
│  ├── Kconfig.suit_provisioning
│  ├── suit_provisioning
│  │  ├── Kconfig.nrf9280
│  │  │ nrf9280.cmake

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 47
✅ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud
- ⚠️ test-sdk-dfu

Note: This message is automatically posted and updated by the CI

nordicjm

2 comments are optional, rest are required

subsys/suit/mci/Kconfig

subsys/suit/memory_layout/Kconfig

subsys/suit/provisioning/CMakeLists.txt

subsys/suit/provisioning/Kconfig

subsys/suit/provisioning/soc/Kconfig.nrf9280

NordicBuilder · 2024-11-04T10:47:44Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

NordicBuilder · 2024-11-04T11:02:34Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

subsys/suit/provisioning/soc/Kconfig.nrf9280

subsys/suit/stream/Kconfig

subsys/suit/storage/src/suit_storage_nrf9280.c

subsys/suit/mci/src/suit_mci_nrf9280.c

NordicBuilder · 2024-11-27T11:31:03Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

subsys/suit/provisioning/CMakeLists.txt

subsys/suit/mci/src/suit_mci_nrf9280.c

config/suit/templates/nrf9280/default/v1/app_recovery_envelope_direct.yaml.jinja2

west.yml

subsys/suit/mci/Kconfig

subsys/suit/storage/Kconfig

subsys/suit/validator/Kconfig

ahasztag

I do not see any blockers to merge this

config/suit/templates/nrf9280/default/v1/app_envelope.yaml.jinja2

ahasztag · 2025-01-24T07:53:18Z

subsys/suit/mci/src/suit_mci_nrf9280.c

+	return false;
+}
+
+mci_err_t suit_mci_signing_key_id_validate(const suit_manifest_class_id_t *class_id,


There is an upcoming change to this function (it will be renamed + little change in functionality in here): https://github.com/nrfconnect/sdk-nrf/pull/20050/files#diff-5f831b3a82f1e14d189946f985f443439e1f68e17d67551dc146b0f47735fe18R161 - depending on which PR will come first we will have to align this in one PR or the other

subsys/nrf_security/Kconfig

subsys/nrf_security/src/drivers/cracen/Kconfig

subsys/suit/storage/Kconfig

sysbuild/suit_provisioning/Kconfig.nrf9280

Add SUIT support for nRF9280 EngB product. Signed-off-by: Tuomas Parttimaa <[email protected]>

stale

carlescufi

All comments addressed

mparpala added the DNM label Nov 4, 2024

mparpala requested review from a team as code owners November 4, 2024 10:30

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 4, 2024

nordicjm previously requested changes Nov 4, 2024

View reviewed changes

mparpala requested a review from a team as a code owner November 4, 2024 11:02

github-actions bot added the manifest label Nov 4, 2024

NordicBuilder added the manifest-suit-generator label Nov 4, 2024

tomchy requested changes Nov 5, 2024

View reviewed changes

anttik-nordic requested a review from a team as a code owner November 18, 2024 14:12

parttimaa force-pushed the nrf9280_suit branch 2 times, most recently from ce5733a to 5625d67 Compare November 27, 2024 11:05

tomchy reviewed Dec 12, 2024

View reviewed changes

subsys/suit/provisioning/CMakeLists.txt Outdated Show resolved Hide resolved

tomchy reviewed Dec 12, 2024

View reviewed changes

subsys/suit/mci/src/suit_mci_nrf9280.c Outdated Show resolved Hide resolved

subsys/suit/mci/src/suit_mci_nrf9280.c Show resolved Hide resolved

ahasztag requested changes Dec 13, 2024

View reviewed changes

subsys/suit/mci/src/suit_mci_nrf9280.c Show resolved Hide resolved

parttimaa force-pushed the nrf9280_suit branch 3 times, most recently from 57e182a to 13bb933 Compare December 16, 2024 12:58

NordicBuilder removed the DNM label Dec 20, 2024

tomchy reviewed Jan 2, 2025

View reviewed changes

config/suit/templates/nrf9280/default/v1/app_recovery_envelope_direct.yaml.jinja2 Outdated Show resolved Hide resolved

parttimaa force-pushed the nrf9280_suit branch from f3dd4ad to 1643daf Compare January 2, 2025 11:31

tomchy approved these changes Jan 3, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

ahasztag requested changes Jan 3, 2025

View reviewed changes

west.yml Outdated Show resolved Hide resolved

github-actions bot removed the manifest label Jan 3, 2025

NordicBuilder removed the manifest-suit-generator label Jan 3, 2025

parttimaa force-pushed the nrf9280_suit branch from fc4dd63 to 7f276c1 Compare January 3, 2025 10:08

github-actions bot added the manifest label Jan 3, 2025

NordicBuilder added the manifest-suit-generator label Jan 3, 2025

parttimaa force-pushed the nrf9280_suit branch from 7f276c1 to 63692db Compare January 9, 2025 07:41

github-actions bot removed the manifest label Jan 9, 2025

NordicBuilder removed the manifest-suit-generator label Jan 9, 2025

parttimaa force-pushed the nrf9280_suit branch from 63692db to 3658d2e Compare January 13, 2025 09:50

github-actions bot added the manifest label Jan 13, 2025

NordicBuilder added the manifest-zephyr label Jan 13, 2025

parttimaa force-pushed the nrf9280_suit branch 2 times, most recently from 16405ab to 6cef595 Compare January 16, 2025 11:26

github-actions bot removed the manifest label Jan 16, 2025

NordicBuilder removed the manifest-zephyr label Jan 16, 2025

mparpala requested review from nordicjm and ahasztag January 23, 2025 06:27

nordicjm reviewed Jan 24, 2025

View reviewed changes

subsys/suit/mci/Kconfig Outdated Show resolved Hide resolved

subsys/suit/storage/Kconfig Outdated Show resolved Hide resolved

subsys/suit/validator/Kconfig Outdated Show resolved Hide resolved

ahasztag approved these changes Jan 24, 2025

View reviewed changes

parttimaa force-pushed the nrf9280_suit branch 2 times, most recently from e00722d to 0d32316 Compare January 29, 2025 06:24

nordicjm reviewed Jan 29, 2025

View reviewed changes

parttimaa force-pushed the nrf9280_suit branch from 0d32316 to fb238ff Compare February 5, 2025 07:23

suit: nRF9280 SUIT support

d7b37b4

Add SUIT support for nRF9280 EngB product. Signed-off-by: Tuomas Parttimaa <[email protected]>

parttimaa force-pushed the nrf9280_suit branch from fb238ff to d7b37b4 Compare February 5, 2025 08:48

parttimaa requested a review from nordicjm February 5, 2025 09:01

carlescufi approved these changes Feb 5, 2025

View reviewed changes

carlescufi merged commit 1ca722f into nrfconnect:main Feb 5, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

suit: nRF9280 SUIT support #18496

suit: nRF9280 SUIT support #18496

mparpala commented Nov 4, 2024 •

edited by parttimaa

Loading

CLAassistant commented Nov 4, 2024 •

edited

Loading

NordicBuilder commented Nov 4, 2024 •

edited

Loading

nordicjm left a comment

NordicBuilder commented Nov 4, 2024

NordicBuilder commented Nov 4, 2024 •

edited

Loading

NordicBuilder commented Nov 27, 2024

This comment was marked as resolved.

ahasztag left a comment

ahasztag Jan 24, 2025

carlescufi left a comment

suit: nRF9280 SUIT support #18496

suit: nRF9280 SUIT support #18496

Conversation

mparpala commented Nov 4, 2024 • edited by parttimaa Loading

CLAassistant commented Nov 4, 2024 • edited Loading

NordicBuilder commented Nov 4, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

nordicjm left a comment

Choose a reason for hiding this comment

NordicBuilder commented Nov 4, 2024

NordicBuilder commented Nov 4, 2024 • edited Loading

NordicBuilder commented Nov 27, 2024

This comment was marked as resolved.

ahasztag left a comment

Choose a reason for hiding this comment

ahasztag Jan 24, 2025

Choose a reason for hiding this comment

carlescufi left a comment

Choose a reason for hiding this comment

mparpala commented Nov 4, 2024 •

edited by parttimaa

Loading

CLAassistant commented Nov 4, 2024 •

edited

Loading

NordicBuilder commented Nov 4, 2024 •

edited

Loading

NordicBuilder commented Nov 4, 2024 •

edited

Loading