Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrfx 5953 add device pm to spim #17945

Merged

Conversation

adamkondraciuk
Copy link
Contributor

No description provided.

@adamkondraciuk adamkondraciuk requested review from a team as code owners October 16, 2024 15:33
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 16, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 16, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@6ccfcdc nrfconnect/sdk-zephyr@b20e5fd (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 16, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 13

Inputs:

Sources:

sdk-nrf: PR head: c4fb9672ef7117163ba1c92bc9a41c2c2f504c5f
zephyr: PR head: b20e5fdd43e04340b482d0f703ff626d0905f82d

more details

sdk-nrf:

PR head: c4fb9672ef7117163ba1c92bc9a41c2c2f504c5f
merge base: 5cfc27d3b80a4646f9af8598d0af4585e5f4762f
target head (main): 504a1446cbe433a7e2c482bc61daacfc02d228a8
Diff

zephyr:

PR head: b20e5fdd43e04340b482d0f703ff626d0905f82d
merge base: 6ccfcdc1051d9d405f694882beb4f306ae518b5c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (62)
tests
│  ├── benchmarks
│  │  ├── multicore
│  │  │  ├── idle_spim
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  ├── doc
│  │  │  │  │  │ index.rst
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp_0_9_0.yaml
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad_0_9_0.yaml
│  │  │  ├── nrf54l15dk
│  │  │  │  ├── doc
│  │  │  │  │  │ index.rst
│  │  │  ├── nrf54l15pdk
│  │  │  │  ├── doc
│  │  │  │  │  │ index.rst
│  ├── drivers
│  │  ├── adc
│  │  │  │ adc_nrfx_saadc.c
│  │  ├── dp
│  │  │  ├── swdp_bitbang.c
│  │  │  │ swdp_ll_pin.h
│  │  ├── retained_mem
│  │  │  │ Kconfig.nrf
│  │  ├── spi
│  │  │  │ spi_nrfx_spim.c
│  ├── dts
│  │  ├── arm
│  │  │  ├── nordic
│  │  │  │  ├── nrf51822.dtsi
│  │  │  │  ├── nrf52805.dtsi
│  │  │  │  ├── nrf52810.dtsi
│  │  │  │  ├── nrf52811.dtsi
│  │  │  │  ├── nrf52832.dtsi
│  │  │  │  ├── nrf52833.dtsi
│  │  │  │  ├── nrf52840.dtsi
│  │  │  │  ├── nrf5340_cpuapp.dtsi
│  │  │  │  ├── nrf5340_cpuappns.dtsi
│  │  │  │  ├── nrf91.dtsi
│  │  │  │  │ nrf91ns.dtsi
│  │  ├── common
│  │  │  ├── nordic
│  │  │  │  ├── nrf54h20.dtsi
│  │  │  │  ├── nrf54l15.dtsi
│  │  │  │  ├── nrf54l20.dtsi
│  │  │  │  ├── nrf9280.dtsi
│  │  │  │  │ nrf_common.dtsi
│  ├── include
│  │  ├── zephyr
│  │  │  ├── dt-bindings
│  │  │  │  ├── adc
│  │  │  │  │  ├── nrf-adc.h
│  │  │  │  │  ├── nrf-saadc-nrf54l.h
│  │  │  │  │  ├── nrf-saadc-v2.h
│  │  │  │  │  ├── nrf-saadc-v3.h
│  │  │  │  │  │ nrf-saadc.h
│  ├── samples
│  │  ├── boards
│  │  │  ├── nordic
│  │  │  │  ├── system_off
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── sample.yaml
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  ├── drivers
│  │  │  ├── adc
│  │  │  │  ├── adc_dt
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  ├── adc_sequence
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54l
│  │  │  │  ├── Kconfig
│  │  │  │  │ soc.c
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── host
│  │  │  │  ├── Kconfig
│  │  │  │  ├── conn.c
│  │  │  │  ├── conn_internal.h
│  │  │  │  │ hci_core.c
│  │  ├── net
│  │  │  │ CMakeLists.txt
│  ├── tests
│  │  ├── drivers
│  │  │  ├── retained_mem
│  │  │  │  ├── api
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.conf
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad.conf
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad.overlay
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │ testcase.yaml
│  │  │  ├── spi
│  │  │  │  ├── spi_controller_peripheral
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_common.dtsi
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp_fast.overlay
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  ├── spi_loopback
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf51dk_nrf51822.overlay
│  │  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  │  ├── nrf52dk_nrf52832.overlay
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp_fast.overlay
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  │  │ nrf9160dk_nrf9160.overlay

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 12
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-zigbee
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@adamkondraciuk adamkondraciuk force-pushed the NRFX-5953-Add-device-PM-to-SPIM branch from ca8bead to 925ecce Compare October 16, 2024 15:47
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

*/

&spi131 {
zephyr,pm-device-runtime-auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be set at the board definition?
At least @gmarull is doing that for CAN in https://github.com/zephyrproject-rtos/zephyr/pull/78854/files

@adamkondraciuk adamkondraciuk force-pushed the NRFX-5953-Add-device-PM-to-SPIM branch from 925ecce to 11d48ca Compare October 17, 2024 07:31
@adamkondraciuk adamkondraciuk added this to the 2.8.0 milestone Oct 17, 2024
@adamkondraciuk adamkondraciuk force-pushed the NRFX-5953-Add-device-PM-to-SPIM branch from 11d48ca to 78b8e68 Compare October 17, 2024 11:56
@adamkondraciuk adamkondraciuk force-pushed the NRFX-5953-Add-device-PM-to-SPIM branch 5 times, most recently from 792322c to 4ebb825 Compare October 21, 2024 09:09
Add configuration to idle_spim test for the device runtime PM.

Signed-off-by: Adam Kondraciuk <[email protected]>
Add device runtime power management for SPIM peripheral.

Signed-off-by: Adam Kondraciuk <[email protected]>
@adamkondraciuk adamkondraciuk force-pushed the NRFX-5953-Add-device-PM-to-SPIM branch from 4ebb825 to c4fb967 Compare October 21, 2024 13:46
@NordicBuilder NordicBuilder removed the DNM label Oct 21, 2024
@rlubos rlubos merged commit 0dba33c into nrfconnect:main Oct 21, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants