lib: st25r3911b: Correct regulator control register defines #17492
Conversation
github-actions
bot
added
the
changelog-entry-required
|
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
? |
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
? |
|
Thank you for the contribution! I have been on a long leave and haven't noticed this PR upon return. I'll give it a look tomorrow. |
It's too #17491 |
|
@Andrew55529 please modify the top line of the commit message by adding the area of change followed by a colon. E.g. "st25r3911b: Correct regulator (...)" keeping in mind the max line length of the commit message: 75 characters. |
It's my first PR. I should make 'git commit --amend' or recreate PR with new commit or click any button on GitHub? |
Please use git commit --amend. Zephyr and consequently NCS are quite strict on git history and commit message format, and there is an automated compliance checker that verifies it. |
Andrew55529
changed the title
Andrew55529
force-pushed
the
patch-2
branch
2 times, most recently
from
40376c7 to
e369a54
Compare
|
@grochu It's correct? |
Hi @Andrew55529, thanks for fixing, yeah, the PR looks good now. Let's run the full CI. |
|
Seems like the commit message still needs a bit of refining. Please find the guidelines here: https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines. |
Correct regulator control register defines - Add ST25R3911B_REG_REGULATOR_CTRL_REGE1 - Shifted other REG Fixes a possible error when attempting to autocalibrate the regulator Signed-off-by: Andrei Lashkov <[email protected]>
|
@grochu Attempt number 2 |
grochu
added
the
CI-trusted-author
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-17492/2) |
|
Hi @Andrew55529 could you please rebase your PR on top of ncs/main again? Maybe CI is failing due to the code being outdated. |
Fixes a possible error when attempting to autocalibrate the regulator