Correction of errors in voltage calculation #17491
Conversation
|
|
github-actions
bot
added
the
changelog-entry-required
|
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
@grochu Renamed |
|
Please add the "Signed-off-by" line and include your full name and email address. As well keep all lines in the message less or equal to 72 characters. |
|
Why its failed? |
The error log says: |
|
The documentation states that i do not need to specify a nickname, but a real name. I used git commit -s —amend, but replaced the substituted nickname with a name. My email matches. |
In official documentation on st 25r3911 when we measure voltage, one LSB represents 23.438 mV. When calculating, we multiply the fractional part by a three-digit number. When restoring, we divide it by 100, not by 1000. This is an error. Signed-off-by: Andrew55529 <[email protected]>
|
I don't have a clue for now, let me check with someone else. |
grochu
added
CI-trusted-author
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-17491/2) |
|
Hi @Andrew55529 could you please rebase your PR on top of ncs/main again? Maybe CI is failing due to the code being outdated. |
In official documentation on st 25r3911 when we measure voltage, one LSB represents 23.438 mV. When calculating, we multiply the fractional part by a three-digit number. When restoring, we divide it by 100, not by 1000. This is an error.