Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update requirements for nrf-regtool #16958

Closed
wants to merge 2 commits into from
Closed

tools: update requirements for nrf-regtool #16958

wants to merge 2 commits into from

Conversation

PerMac
Copy link
Contributor

@PerMac PerMac commented Aug 21, 2024

5.6.0 is required by
https://github.com/zephyrproject-rtos/zephyr/
blob/main/modules/hal_nordic/CMakeLists.txt#L15.

@PerMac
tools: update requirements for nrf-regtool
5d67002 
5.6.0 is required by
https://github.com/zephyrproject-rtos/zephyr/
blob/main/modules/hal_nordic/CMakeLists.txt#L15.

Signed-off-by: Maciej Perkowski <[email protected]>
@PerMac PerMac requested a review from gmarull August 21, 2024 14:43
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 21, 2024
@PerMac PerMac requested a review from jangalda-nsc August 21, 2024 14:43
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 21, 2024 •
edited
Loading

The changes to the 'requirements-fixed.txt' have been added to this PR.
All further changes to any of the requirements file will automatically be applied as long an 👀 is present.

Note: This comment is automatically posted and updated by the Comment GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 21, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 78095e2507913ee436b414960aaa0cea3b5bc193

more details

sdk-nrf:

PR head: 78095e2507913ee436b414960aaa0cea3b5bc193
merge base: 72b43d22b0e8342cacbce17e198a3829d5612705
target head (main): 72b43d22b0e8342cacbce17e198a3829d5612705> Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
scripts
│  ├── requirements-build.txt
│  │ requirements-fixed.txt

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disable integration tests
    • desktop52_verification
    • doc-internal
    • latest/ble/nrf/test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
ci: Updating requirements-fixed.txt
78095e2 
This is an automated commit from github workflow by NordicBuilder

Signed-off-by: Nordic Builder <[email protected]>
gmarull
gmarull requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires bringing pinctrl clockpin changes

@shanthanordic shanthanordic requested a review from 57300 August 21, 2024 18:56
@shanthanordic
Copy link

@57300 should approve this PR before merging.

@PerMac
Copy link
Contributor Author

PerMac commented Aug 22, 2024

this requires bringing pinctrl clockpin changes

I assume those will come with the ongoing upmerge? Without newer regtool nrf54h20 prints no output. We can get it installed within our CI for now to unlock testing.

@gmarull
Copy link
Member

gmarull commented Aug 22, 2024 •
edited
Loading

this requires bringing pinctrl clockpin changes

I assume those will come with the ongoing upmerge? Without newer regtool nrf54h20 prints no output. We can get it installed within our CI for now to unlock testing.

I guess this is upstream only, not downstream. They'll come with the next upmerge, if not, they can be easily cherry-picked in advance

57300
57300 requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@57300 57300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required pinctrl changes are expected to go in with nrfconnect/sdk-zephyr#1952

@57300
Copy link
Contributor

57300 commented Sep 13, 2024

Updated as part of #17197

@57300 57300 closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarull gmarull gmarull requested changes

@57300 57300 57300 requested changes

@tejlmand tejlmand Awaiting requested review from tejlmand

@grho grho Awaiting requested review from grho

@shanthanordic shanthanordic Awaiting requested review from shanthanordic

@ihansse ihansse Awaiting requested review from ihansse

@jangalda-nsc jangalda-nsc Awaiting requested review from jangalda-nsc

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PerMac @NordicBuilder @shanthanordic @gmarull @57300