samples: matter: Refactored diagnostic crash logs module #15455
Conversation
kkasperczyk-no
requested review from
Damian-Nordic,
carlescufi and
tejlmand
as code owners
github-actions
bot
added
doc-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
samples/matter/common/src/diagnostic/diagnostic_logs_provider.h
Outdated
Show resolved
Hide resolved
samples/matter/common/src/diagnostic/diagnostic_logs_provider.h
Outdated
Show resolved
Hide resolved
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
kkasperczyk-no
force-pushed
the
crash_logs_refactor
branch
from
ea68f95 to
9903e74
Compare
kkasperczyk-no
force-pushed
the
crash_logs_refactor
branch
2 times, most recently
from
8dacfc7 to
e7787ff
Compare
samples/matter/common/src/diagnostic/diagnostic_logs_provider.h
Outdated
Show resolved
Hide resolved
samples/matter/common/src/diagnostic/diagnostic_logs_provider.h
Outdated
Show resolved
Hide resolved
kkasperczyk-no
force-pushed
the
crash_logs_refactor
branch
from
e7787ff to
831bf4d
Compare
Refactored and enhanced diagnostic crash logs module: * Extracted crash logs specific methods from generic diagnostic logs provider to the diagnostic logs crash module. * Removed usage of persistent storage as a back-up for the retention RAM memory * Added saving intent implementation object as a part of mIntentMap what allows to perform several independent log collection sessions at the same time. Signed-off-by: Kamil Kasperczyk <[email protected]>
kkasperczyk-no
force-pushed
the
crash_logs_refactor
branch
from
831bf4d to
e95bdbd
Compare
| mIntent = other.mIntent; | ||
| mIntentImpl = other.mIntentImpl; | ||
| /* Nullptr the copied data to prevent from deleting it by the source. */ | ||
| other.mIntentImpl = nullptr; |
There was a problem hiding this comment.
nit: we should also invalidate the intent with IntentEnum::kUnknownEnumValue.
There was a problem hiding this comment.
I will add it in the next PR. I will open it just after merging this one.
| return *this; | ||
| } | ||
|
|
||
| operator bool() const { return true; } |
There was a problem hiding this comment.
| operator bool() const { return true; } | |
| operator bool() const { return mIntentImpl && (mIntent != IntentEnum::kUnknownEnumValue); } |
?
There was a problem hiding this comment.
For now mIntentImpl can be nullptr. This is needed,because we don't have network logs implementation and we want to use it for testing purposes.
Refactored and enhanced diagnostic crash logs module: