Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: rework PM static partitions for nRF54L #15340

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

markaj-nordic
Copy link
Contributor

@markaj-nordic markaj-nordic commented May 16, 2024

  • enabled mx25r64 external flash over SPI for Matter samples
  • added pm_static* files that configures static memory map with
    MCUboot secondary slot residing on the external flash
  • added MCUboot configuration to support DFU
  • increased the RRAM and SRAM for nrf54L (by default the FLPR
    consumes 68k of SRAM and 96k of RRAM even if not used)
  • left the pm_static file with internal flash only for the
    template sample as a reference for dual bank DFU with no
    external flash
  • disabled HWFC for uart20 as it is highly unstable
  • added support for nRF54L platform in the lock sample
  • updated documentation to describe supported DFU variants

test_chip: PR-765

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 16, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 16, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 16, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@0ae05f2 nrfconnect/sdk-connectedhomeip@b0acf15 (master) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from 485f34e to f4dc28c Compare May 16, 2024 15:53
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 16, 2024
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from f4dc28c to 20366d1 Compare May 16, 2024 16:00
@NordicBuilder NordicBuilder removed the DNM label May 16, 2024
@markaj-nordic markaj-nordic requested a review from wiba-nordic May 17, 2024 04:45
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from f2f3d80 to 42224d9 Compare May 17, 2024 12:23
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 17, 2024
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be adapted and go in after sysbuild ncs PR

@markaj-nordic markaj-nordic requested a review from nordicjm May 28, 2024 20:48
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from 55a3e59 to ab788c8 Compare May 28, 2024 20:57
Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, please consider removing the _release dts files. I guess they may be redundant here.

@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch 4 times, most recently from 6317b6e to 4786440 Compare May 31, 2024 18:21
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from 4786440 to bb5130e Compare June 1, 2024 22:56
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from bb5130e to 4c1e817 Compare June 3, 2024 09:41
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from 4c1e817 to fb72b81 Compare June 3, 2024 22:35
@nordicjm
Copy link
Contributor

nordicjm commented Jun 4, 2024

merge conflict

@ArekBalysNordic ArekBalysNordic added this to the 2.7.0 milestone Jun 4, 2024
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from fb72b81 to 3384f19 Compare June 4, 2024 12:36
@markaj-nordic
Copy link
Contributor Author

merge conflict

Fixed.

@markaj-nordic markaj-nordic requested a review from doublemis1 June 4, 2024 12:40
* enabled mx25r64 external flash over SPI for Matter samples
* added pm_static* files that configures static memory map with
  MCUboot secondary slot residing on the external flash
* added MCUboot configuration to support DFU
* increased the RRAM and SRAM for nrf54L (by default the FLPR
  consumes 68k of SRAM and 96k of RRAM even if not used)
* left the pm_static file with internal flash only for the
  template sample as a reference for dual bank DFU with no
  external flash
* disabled HWFC for uart20 as it is highly unstable
* added support for nRF54L platform in the lock sample
* updated documentation to describe supported DFU variants

Signed-off-by: Marcin Kajor <[email protected]>
@markaj-nordic markaj-nordic force-pushed the matter_nrf54l_ext_flash branch from 3384f19 to 3e74ba6 Compare June 4, 2024 16:58
@NordicBuilder NordicBuilder removed the DNM label Jun 4, 2024
@rlubos rlubos merged commit a552dbc into nrfconnect:main Jun 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants