samples: matter: Add Event Trigger support for all samples #14511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
requested review from
kkasperczyk-no,
wiba-nordic and
markaj-nordic
ArekBalysNordic
requested review from
Damian-Nordic and
carlescufi
as code owners
github-actions
bot
added
the
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
b479cd4 to
0669b20
Compare
wiba-nordic
requested changes
Mar 14, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
2 times, most recently
from
80a28a5 to
8ec8f96
Compare
wiba-nordic
requested changes
Mar 14, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
ArekBalysNordic
force-pushed
the
event_triggers
branch
2 times, most recently
from
d1d48c9 to
891369e
Compare
wiba-nordic
requested changes
Mar 15, 2024
samples/matter/common/src/event_triggers/default_event_triggers.cpp
Outdated
Show resolved
Hide resolved
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
891369e to
c4da098
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
c4da098 to
94cce67
Compare
|
@wiba-nordic I've added the new section to docs: |
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
94cce67 to
4f67784
Compare
wiba-nordic
requested changes
Mar 18, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
4f67784 to
0584a54
Compare
wiba-nordic
requested changes
Mar 19, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
0584a54 to
bcb873b
Compare
wiba-nordic
approved these changes
Mar 19, 2024
LuDuda
reviewed
Mar 21, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
bcb873b to
333414f
Compare
|
@LuDuda @wiba-nordic I've moved information regarding certification to the top of the page. Could you please verify whether it is more clear now? @markaj-nordic I edited FiniteMap, and now the key can be various, please verify it :) |
wiba-nordic
requested changes
Mar 22, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
333414f to
01f4f9d
Compare
wiba-nordic
approved these changes
Mar 22, 2024
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
01f4f9d to
561bf58
Compare
LuDuda
approved these changes
Mar 22, 2024
| When you provide the enable key using factory data, you can utilize the event trigger feature during the Matter Certification process. | ||
| This is because, when done this way, you can turn off the event trigger functionality by disabling access to the ``generaldiagnostics`` cluster without altering the code that has already been certified. | ||
|
|
||
| Once the certification process is complete, you can deactivate the test event trigger functionality by generating new factory data with a modified enable key value. |
There was a problem hiding this comment.
you can or you must -- or my understanding is wrong?
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
561bf58 to
40ed2fc
Compare
Moved finite map implementation from bridge_util to common util to make it available for all samples. Made the finite map more versatile, by defining the key as a template of trivial typename. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
40ed2fc to
bfc0c73
Compare
markaj-nordic
approved these changes
Mar 26, 2024
Matter test events can be used by the Matter controller to trigger specific device's behavior. Added a mechanism to register event triggers and use their callbacks through Matter Controller. Added the documentation page to describe the mechanism and create a list of the currently available default event triggers. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
event_triggers
branch
from
bfc0c73 to
4255a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matter test events can be used by the Matter controller
to trigger specific device's behavior.
Added a mechanism to register event triggers and use their
callbacks through Matter Controller.
Added the documentation page to describe the mechanism and
create a list of the currently available default event triggers.