Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smp svr for nrf54l15 #14475

Closed
wants to merge 3 commits into from
Closed

smp svr for nrf54l15 #14475

wants to merge 3 commits into from

Conversation

michalek-no
Copy link
Contributor

No description provided.

@michalek-no michalek-no requested review from a team, carlescufi and tejlmand as code owners March 11, 2024 14:19
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 11, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 11, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@ecb16c7 nrfconnect/sdk-zephyr#1580 nrfconnect/sdk-zephyr#1580/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm
nordicjm requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@nvlsianpu
Copy link
Contributor

@nordicjm We have objective (form Projects management team) to expose DFU sample for NCS which will build right away. It was decided that code should base on the zephyr smp_svr. We will support (mainly configuration) for more platform there.

@nordicjm
Copy link
Contributor

@nordicjm We have objective (form Projects management team) to expose DFU sample for NCS which will build right away. It was decided that code should base on the zephyr smp_svr. We will support (mainly configuration) for more platform there.

Just build smp_svr? What value does this even add?

@nvlsianpu
Copy link
Contributor

  • This aim to build with our NSC flavoured build system, including Partition manager
  • This is place where we can add our configuration (if needed)
  • we will add NCS specific README there

@nordicjm
Copy link
Contributor

nordicjm commented Mar 11, 2024 •
edited
Loading

Partition manager is on it's way out so it doesn't make sense for that also note that communication was sent out some time ago that no new features are to be added to partition manager and it is bug fixes and maintenance only. And note that config files can and have been added to sdk-zephyr for this specific sample: https://github.com/nrfconnect/sdk-zephyr/tree/main/samples/subsys/mgmt/mcumgr/smp_svr

nvlsianpu
nvlsianpu reviewed Mar 11, 2024
View reviewed changes
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 12, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-thread X
test-fw-nrfconnect-zigbee X
test-low-level X
test-sdk-find-my X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

gchwier
gchwier requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gchwier gchwier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing sample.yaml file for Twister

samples/smp_svr/boards/nrf54l15pdk_nrf54l15_cpuapp.conf Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be moved to prj.conf, this is common config, not only for nrf54l15

samples/smp_svr/boards/nrf54l15pdk_nrf54l15_cpuapp.overlay Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need it? Why to change default uart20, that is used in the Upstream?

@michalek-no michalek-no force-pushed the ncs-mb-smp-svr branch 3 times, most recently from 171eb90 to 3173fee Compare March 14, 2024 15:09
@shanthanordic shanthanordic removed the request for review from a team March 15, 2024 08:29
@github-actions github-actions bot removed the manifest label Mar 15, 2024
@michalek-no michalek-no requested a review from gchwier March 15, 2024 09:18
michalek-no and others added 2 commits March 19, 2024 14:10
@michalek-no
samples: smp_svr for nrf54l15
bcaf1cf 
BT and shell transport.

Signed-off-by: Mateusz Michalek <[email protected]>
@nvlsianpu @michalek-no
drivers/mpsl/flash_synch: MPSL choice for nRF54L15
5da926e 
Made MPSL based synchronization mechanism available for
nRF54L15 too.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
@michalek-no michalek-no requested a review from anangl as a code owner March 19, 2024 13:27
@michalek-no
manifest: sdk-zephyr
ef98f7f 
Correct rram write size.

Signed-off-by: Mateusz Michalek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvlsianpu nvlsianpu nvlsianpu left review comments

@nordicjm nordicjm nordicjm requested changes

@sigvartmh sigvartmh Awaiting requested review from sigvartmh

@de-nordic de-nordic Awaiting requested review from de-nordic

@jumi-nordic jumi-nordic Awaiting requested review from jumi-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@gchwier gchwier Awaiting requested review from gchwier

@anangl anangl Awaiting requested review from anangl

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalek-no @NordicBuilder @nvlsianpu @nordicjm @gchwier