samples: Matter: light_bulb: Add support for AWS IoT #12876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
2 times, most recently
from
fcf6fb6 to
6c5b09d
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
12 times, most recently
from
6ae6598 to
470da91
Compare
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
4 times, most recently
from
dbf0efc to
7151116
Compare
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
7151116 to
1c02b91
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
2 times, most recently
from
930050e to
c561f9b
Compare
There was a problem hiding this comment.
Thanks for your contribution. I left some initial comments from the integration perspective. I think that we also miss:
- README update with information how this build could be enabled and tested
- Entry in samples.yml that would at least verify the building process passes.
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
c561f9b to
9eaa2bd
Compare
I am working on the figures and reviewing the documents. @wiba-nordic - Maybe you could take a look once I complete my part of the review? I will keep you posted. |
doublemis1
approved these changes
Dec 13, 2023
jtguggedal
reviewed
Dec 13, 2023
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
divipillai
force-pushed
the
matter-aws-iot-brige
branch
from
9c50f11 to
d3bc74a
Compare
wiba-nordic
requested changes
Dec 15, 2023
divipillai
force-pushed
the
matter-aws-iot-brige
branch
2 times, most recently
from
acba916 to
d84bd44
Compare
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
d84bd44 to
3521827
Compare
simensrostad
requested review from
wiba-nordic,
kkasperczyk-no and
jtguggedal
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
2 times, most recently
from
a5c650a to
d2c0d45
Compare
divipillai
approved these changes
Dec 15, 2023
kkasperczyk-no
approved these changes
Dec 18, 2023
wiba-nordic
approved these changes
Dec 18, 2023
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
d2c0d45 to
f013f7b
Compare
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
f013f7b to
5e0e024
Compare
wiba-nordic
reviewed
Dec 20, 2023
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
cb15616 to
3413788
Compare
wiba-nordic
approved these changes
Dec 20, 2023
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
2 times, most recently
from
5216e54 to
c4272fa
Compare
Add types for subscribed topics and include the type in the received payload. Makes it easier to perform different actions based on topic type in the application. Signed-off-by: Simen S. Røstad <[email protected]>
Add support for AWS IoT Signed-off-by: Simen S. Røstad <[email protected]>
simensrostad
force-pushed
the
matter-aws-iot-brige
branch
from
c4272fa to
d9647ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for AWS IoT