From a026b42bd67f13d3d9cd904a63b8b97b60f30a91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Sigurdsen=20R=C3=B8stad?= <42843330+simensrostad@users.noreply.github.com> Date: Fri, 24 Jan 2025 14:00:09 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Divya S Pillai <91891495+divipillai@users.noreply.github.com> Co-authored-by: Pekka Niskanen <73991005+peknis@users.noreply.github.com> --- doc/nrf/libraries/debug/memfault_ncs.rst | 2 +- .../releases/release-notes-changelog.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/nrf/libraries/debug/memfault_ncs.rst b/doc/nrf/libraries/debug/memfault_ncs.rst index 156200c870bb..573d4b8c75e2 100644 --- a/doc/nrf/libraries/debug/memfault_ncs.rst +++ b/doc/nrf/libraries/debug/memfault_ncs.rst @@ -70,7 +70,7 @@ If at any point the network is lost during the retry process, the library waits This feature is useful when you want to post the coredump as soon as possible after a crash and it is not desirable to wait for the next periodic upload set by :kconfig:option:`CONFIG_MEMFAULT_HTTP_PERIODIC_UPLOAD_INTERVAL_SECS`. Alternatively, you can manually trigger the coredump upload by calling the function :c:func:`memfault_zephyr_port_post_data`. -The :c:function:`memfault_coredump_has_valid_coredump` function can be used to check if a coredump is available. +The :c:func:`memfault_coredump_has_valid_coredump` function can be used to check if a coredump is available. Configuration options in Memfault SDK ===================================== diff --git a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst index ad2c35400843..0d1f01552318 100644 --- a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst +++ b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst @@ -227,7 +227,7 @@ nRF Machine Learning (Edge Impulse) Serial LTE modem ---------------- -* Added overlay :file:`overlay-memfault.conf` to enable Memfault. +* Added an overlay :file:`overlay-memfault.conf` file to enable Memfault. For more information about Memfault features in |NCS|, see :ref:`mod_memfault`. * Updated the application to use the :ref:`lib_downloader` library instead of the deprecated :ref:`lib_download_client` library. @@ -618,7 +618,7 @@ Memfault integration -------------------- * Added a new feature to automatically post coredumps to Memfault when network connectivity is available. - This feature can be enabled by setting the :kconfig:option:`MEMFAULT_NCS_POST_COREDUMP_ON_NETWORK_CONNECTED` Kconfig option to ``y``. + To enable this feature, set the :kconfig:option:`MEMFAULT_NCS_POST_COREDUMP_ON_NETWORK_CONNECTED` Kconfig option to ``y``. Only supported for nRF91 Series devices. AVSystem integration