Fix the way of providing data to generate factory data #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the generation of factory data for nrfconnect platform. Spake2 verifier generated if passcode provided. Signed-off-by: Michał Szablowski <[email protected]>
doublemis1
force-pushed
the
update_factory_reset_generation
branch
from
56d5a9c to
7411e10
Compare
| @@ -99,8 +99,6 @@ def gen_test_certs(chip_cert_exe: str, | |||
| vendor_id: int, | |||
| product_id: int, | |||
| device_name: str, | |||
| generate_cd: bool = False, | |||
There was a problem hiding this comment.
I'm not sure that we can remove that, because some customers can use it to generate their CD. That option doesn't include CD in the FD set, but it generates CD to the build directory.
|
Closing, all tasks from here have been done in: #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the generation of factory data for nrfconnect platform. No more possible to provide spake2 verifier, always generated by provided passcode.