[nrf noup] [zephyr] Fix CHIPDevicePlatformEvent.h include dependencies #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CHIPDevicePlatformEvent depends on the SystemPacketBuffer which is included in the CHIPDeviceEvent.h too late. The problem is silently fixed in the application when the <platform/PlatformManager.h> include is preceded by other headers that pull in SystemPacketBuffer.h. Signed-off-by: Marcin Kajor <[email protected]>
markaj-nordic
requested review from
LuDuda,
kkasperczyk-no,
Damian-Nordic and
ArekBalysNordic
Damian-Nordic
approved these changes
Jan 10, 2024
kkasperczyk-no
approved these changes
Jan 10, 2024
ArekBalysNordic
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CHIPDevicePlatformEvent depends on the SystemPacketBuffer which is included in the
CHIPDeviceEvent.h too late.
The problem is silently worked around in the application when the <platform/PlatformManager.h> include is preceded by other headers that pull in SystemPacketBuffer.h, but we need a proper fix.