Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typographic filter sometimes inserts random $2 #34

Open
alykat opened this issue Nov 14, 2023 · 2 comments
Open

Typographic filter sometimes inserts random $2 #34

alykat opened this issue Nov 14, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alykat
Copy link
Member

alykat commented Nov 14, 2023

Just noted with Books We Love built on the interactive template:
nprapps/book-concierge#119

And noted earlier this year on the midsummer Games We Love built in the dgnext rig.

Non-urgent (there's an easy workaround) but worth looking into one of these days. Rather than modify typogr itself, i'd probably search for that string in in the processed text?

Any change we'd want to apply to BWL, dgnext and the interactive template.

@alykat alykat added bug Something isn't working good first issue Good for newcomers labels Nov 14, 2023
@qmohitsingh
Copy link

hey @alykat, Could you please assign this to me? Thank you

@alykat
Copy link
Member Author

alykat commented Nov 15, 2023

@qmohitsingh thanks for the offer! we already have a fix in another project — it just needs to be migrated over here. we'll handle this in-house.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants