Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color scale buckets in hex map template don't always work properly #255

Open
brmayes opened this issue Dec 26, 2017 · 1 comment
Open

Color scale buckets in hex map template don't always work properly #255

brmayes opened this issue Dec 26, 2017 · 1 comment
Labels
Good Intro Task A relatively small, well-scoped issue for beginning contributors

Comments

@brmayes
Copy link
Contributor

brmayes commented Dec 26, 2017

When making the graphic minimum-wage-2018-increases-20171226, I noticed a problem I and other members of the team have had in the past: the color buckets weren't aligning properly when using the isNumeric flag.

@alykat has fixed this problem before by changing how she rounds in the spreadsheet. She fixed this by using floor and setting the numbers to round down instead of up.
pasted_image_at_2017_08_01_12_49_pm_1024

That didn't work in my case. The fix that @ghing and I came up with was switching the scale from an ordinal scale to threshold and pushing the categories as floats.

Not high priority, but might be worth looking into as an update if we find that problem happening frequently.

@alykat
Copy link
Member

alykat commented Apr 17, 2018

Related: #203

@thomaswilburn thomaswilburn added the Good Intro Task A relatively small, well-scoped issue for beginning contributors label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good Intro Task A relatively small, well-scoped issue for beginning contributors
Projects
None yet
Development

No branches or pull requests

3 participants