Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity/notes regarding the project license #6820

Open
ssddanbrown opened this issue Oct 31, 2024 · 4 comments
Open

Clarity/notes regarding the project license #6820

ssddanbrown opened this issue Oct 31, 2024 · 4 comments
Labels

Comments

@ssddanbrown
Copy link

Hello,

I'm interested in open source licensing and, after looking over the project, just wanted to raise and query a few things I noticed:

  • The License section of your readme makes no mention that other licenses are at play in the project, which could leave some users assuming the is MIT licensed alone.
  • The license badge in your readme is broken, likely because GitHub/Shields no longer sees the license file as a typical known/MIT license file.
  • In regard to the license file itself, it may be better to remove the "MIT License" header since it's no longer just MIT with that addition, and someone may just read that and assume standard MIT. Alternatively, the custom addition could be moved to the top.
  • To understand the existing license terms following the license text, you have to scan the project for license files which is a bit of a pain, especially as there only seems to actually be a single other license? Might be a better just to directly reference that folder and license.
  • Based on a quick search there seems to be a good few references on the ee code from the open code, indicating the ee code is relied upon to run/build the application. If so then users looking to use this as an open source project may be unknowingly using code under your "Novu Proprietary Software License" and therefore unknowingly agreeing to the terms of that license.
Copy link

linear bot commented Oct 31, 2024

@scopsy
Copy link
Contributor

scopsy commented Nov 1, 2024

Hi @ssddanbrown thank you so much for the feedback on this. I completely agree with your findings. I have already updated the Readme License section and working with the team to update the main License file to avoid confusion.

I'm also looking for a solution for the "ee" references in the web package, but this might require some more technical research on our side.

I will update this thread with any progress made 🙏

@insidesmart
Copy link

nice work novu team on the release of v2. product looks very powerful now.

excellent findings/feedback @ssddanbrown on this topic.

just want to chime in another feedback reg opensource / ee offering. it would be very useful to have a webpage (maybe linked from pricing page) to compare the feature set of opensource vs enterprise versions. It would actually help any decision maker to quickly opt for enterprise version, if they badly need an important feature present only in it.

wish novu team good luck for the future.

@scopsy
Copy link
Contributor

scopsy commented Nov 6, 2024

Updated the license files at the root of the project to better reflect the dual-license, and also added an updated licensee section on the readme.md.

@insidesmart will share this with you shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants