Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Ensure Full Proof Transcript is Incorporated into Non-interactive Proofs #45

Open
tyurek opened this issue Jul 26, 2022 · 0 comments
Open

Comments

@tyurek
Copy link
Contributor

tyurek commented Jul 26, 2022

When using Fiat-Shamir for non-interaction, we need to make sure we're incorporating all the public information we need to into the proof transcript before hashing (this is something implementors are still messing up in practice: https://blog.trailofbits.com/2022/04/13/part-1-coordinated-disclosure-of-vulnerabilities-affecting-girault-bulletproofs-and-plonk/ ). This includes information like the session identifier, other player ids, and public variables such as public keys. The paper probably does a good job about specifying what needs to be included, but we need to make sure we're including it (and it's probably best to include anything possibly relevant just in case).

Mechanically, I'm thinking the way to handle this is to allow our zkproofs to take an external transcript

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant