Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI scale - Blender 3.4 #4709

Open
Durman opened this issue Oct 17, 2022 · 9 comments · May be fixed by #4836
Open

UI scale - Blender 3.4 #4709

Durman opened this issue Oct 17, 2022 · 9 comments · May be fixed by #4836
Labels

Comments

@Durman
Copy link
Collaborator

Durman commented Oct 17, 2022

Problem statement

There are some changes in UI scale of Blender 3.4

blender_FrCfkNYxEk.mp4
@Durman
Copy link
Collaborator Author

Durman commented Oct 19, 2022

Probably, similar fixes can be done - https://developer.blender.org/D16251

@satabol
Copy link
Collaborator

satabol commented Dec 21, 2022

I do not see this problem now in Blender 3.4.1. May be close this issue?

TextViewerNoProblemo

@Durman
Copy link
Collaborator Author

Durman commented Dec 21, 2022

image

@portnov
Copy link
Collaborator

portnov commented Dec 21, 2022

probably this is related to HiDPI display somehow? I can't reproduce.

@Durman
Copy link
Collaborator Author

Durman commented Dec 21, 2022

My monitor settings

image

@Durman
Copy link
Collaborator Author

Durman commented Dec 21, 2022

2022-12-21.20-14-50.mp4

@portnov
Copy link
Collaborator

portnov commented Dec 21, 2022

Ah, I see. Never used that option :)

@enzyme69
Copy link
Collaborator

enzyme69 commented Dec 21, 2022

No wonder seems to be same issue that happens with macOS -- when using with SVerchok.

By default, macOS is 2x screen resolution...

Screenshot 2022-12-22 at 8 35 16 am

Screenshot 2022-12-22 at 8 35 21 am

NOTE: I might be the only user of Blender + SVerchok using macOS...

@satabol satabol linked a pull request Dec 22, 2022 that will close this issue
@Durman
Copy link
Collaborator Author

Durman commented Jul 18, 2023

I've tested this more carefully. The node starts to work correctly after removing it and recreating it again. It means that it calls something in its init function. In particular it calls this.

sverchok/node_tree.py

Lines 79 to 85 in 2d9e313

def update_gl_scale_info(self, origin=None):
"""
the nodeview scale and dpi differs between users and must be queried to get correct nodeview
x,y and dpi scale info.
this is instead of calling `get_dpi_factor` on every redraw.
"""

I'm not sure why get_dpi_factor can't be called on each redraw. From my point of view it's just a constant and reading it can't be too expensive especially comparatively to what already is happening in the draw functions.

So the fix should be to include reading ui_scale on each redraw. Probably also some proves, that it does not have significant impact on execution duration, can be added.

P.S. This behavior is related to how it's implemented in Sverchok and is irrelevant to API changes in Blender (though API changes still can have an effect but it might have different symptones).

@Durman Durman removed this from the Sverchok v1.2 milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants