Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open window detection causes delay to heating turning on after offset #5

Open
justcop opened this issue Nov 4, 2021 · 1 comment
Open

Comments

@justcop
Copy link

justcop commented Nov 4, 2021

With open window detection on, as soon as the offset decreases, open window is triggered and there is a resultant delay in turning the heat up.

I would propose checking the state of open window first, then if on, turning it off before changing the offset and then turning it back on.

It looks like there is no service in the integration to do this but certainly possible from the api directly.

I understand, if I'm not mistaken that you maintain the tado integration. Would it be possible to add this service and then I can work on the changes to the blueprint?

Unfortunately my python isn't yet good enough to propose these changes to the integration my self.

@north3221
Copy link
Owner

hey, sorry for the delay... been way too busy to play with any of this... I dont actually maintain the Tado integration but just raised a pr and the guy that does asked me to take over.. so I might... 👀

you will see from the note I left on your pr that i've started looking at this again to get it updated..

Albeit I havent got auto-assist so I dont use open window detection.. Also just had a quick look and doesnt look like setting open window is available in pyTado (which is the underlying Tado api connector that the integration uses) so it would likely need a pr to that first

Appreciate you are saying your python isnt good enough, but I am not python dev, nor any dev... just had to read the code and research to do this stuff... I dont mind taking a look if you gather some info on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants