fix the " or exit " and output redirection on error (#70)

issue NMO-459

- best practice: `<command> || exit` need to change to `<command> ||
exit 1` so that it return an error on logic faillure
- best practice: output redirection need to be from stdout to stder on
error

Author: RedLeader962

import_norlab_shell_script_tools_lib.bash

@@ -30,13 +30,13 @@ function n2st::source_lib(){
   _REPO_ROOT="$(dirname "${_PATH_TO_SCRIPT}")"
 
   # ....Load environment variables from file.......................................................
-  cd "${_REPO_ROOT}" || exit
+  cd "${_REPO_ROOT}" || exit 1
   set -o allexport
   source .env.n2st
   set +o allexport
 
   # ....Begin......................................................................................
-  cd "${N2ST_PATH:?'[ERROR] env var not set!'}/src/function_library" || exit
+  cd "${N2ST_PATH:?'[ERROR] env var not set!'}/src/function_library" || exit 1
   for each_file in "$(pwd)"/*.bash ; do
       source "${each_file}"
   done

src/function_library/docker_utilities.bash

@@ -11,7 +11,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "function_library" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'docker_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'docker_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1

src/function_library/dummy.bash

@@ -16,6 +16,6 @@ function n2st::good_morning_norlab() {
 }
 
 function n2st::this_is_not_cool() {
-    echo -e "\n[\033[1;31mERROR\033[0m] Noooooooooooooo!"
+    echo -e "\n[\033[1;31mERROR\033[0m] Noooooooooooooo!" 1>&2
     return 1
 }

src/function_library/general_utilities.bash

@@ -11,7 +11,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "function_library" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'general_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'general_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -100,7 +100,7 @@ function n2st::set_which_architecture_and_os() {
     elif [[ $(uname) == "Linux" ]]; then
         export IMAGE_ARCH_AND_OS='linux/arm64'
     else
-      echo -e "${MSG_ERROR} Unsupported OS for aarch64 processor"
+      echo -e "${MSG_ERROR} Unsupported OS for aarch64 processor" 1>&2
     fi
   elif [[ $(uname -m) == "arm64" ]] && [[ $(uname) == "Darwin" ]]; then
     export IMAGE_ARCH_AND_OS='darwin/arm64'

src/function_library/prompt_utilities.bash

@@ -12,7 +12,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "function_library" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'prompt_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'prompt_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -rn 1
   exit 1
@@ -98,7 +98,7 @@ function n2st::print_msg_error_and_exit() {
   local ERROR_MSG=$1
 
   echo ""
-  echo -e "${MSG_ERROR}: ${ERROR_MSG}" >&2
+  echo -e "${MSG_ERROR}: ${ERROR_MSG}" 1>&2
   # Note: The >&2 sends the echo output to standard error
   echo "Exiting now."
   echo ""
@@ -109,7 +109,7 @@ function n2st::print_msg_error() {
   local ERROR_MSG=$1
 
   echo ""
-  echo -e "${MSG_ERROR}: ${ERROR_MSG}" >&2
+  echo -e "${MSG_ERROR}: ${ERROR_MSG}" 1>&2
   echo ""
 }
 

src/function_library/teamcity_utilities.bash

@@ -12,7 +12,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "function_library" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'teamcity_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'teamcity_utilities.bash' script must be sourced from the 'function_library/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1

src/function_library/terminal_splash.bash

@@ -320,7 +320,7 @@ function n2st::norlab_splash() {
   else
     MSG_ERROR_FORMAT="\033[1;31m"
     MSG_END_FORMAT="\033[0m"
-    echo -e "${MSG_ERROR_FORMAT}SPLASH_TYPE \"${SPLASH_TYPE}\" not implemented! ${MSG_END_FORMAT}"
+    echo -e "${MSG_ERROR_FORMAT}SPLASH_TYPE \"${SPLASH_TYPE}\" not implemented! ${MSG_END_FORMAT}" 1>&2
   fi
 
 }

src/utility_scripts/install_docker_tools.bash

@@ -13,7 +13,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "utility_scripts" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'install_docker_tools.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'install_docker_tools.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -22,7 +22,7 @@ fi
 # ....Load helper function.........................................................................
 TMP_CWD=$(pwd)
 source ../../.env.n2st
-cd ../function_library || exit
+cd ../function_library || exit 1
 source ./prompt_utilities.bash
 source ./docker_utilities.bash
 cd "${TMP_CWD}"
@@ -77,4 +77,4 @@ n2st::add_user_to_the_docker_group "$(whoami)"
 
 n2st::print_formated_script_footer 'install_docker_tools.bash'
 # ====Teardown=====================================================================================
-cd "${TMP_CWD}"  || exit
+cd "${TMP_CWD}"  || exit 1

src/utility_scripts/which_architecture_and_os.bash

@@ -26,7 +26,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "utility_scripts" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'which_architecture_and_os.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'which_architecture_and_os.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -42,7 +42,7 @@ if [[ -z $PROJECT_PROMPT_NAME ]] && [[ -z $PROJECT_GIT_NAME ]] ; then
   set +o allexport
 fi
 
-cd ../function_library || exit
+cd ../function_library || exit 1
 source ./general_utilities.bash
 
 cd "${TMP_CWD}"

src/utility_scripts/which_python_version.bash

@@ -17,7 +17,7 @@
 
 # ....Pre-condition................................................................................
 if [[ "$(basename "$(pwd)")" != "utility_scripts" ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] 'which_python_version.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'"
+  echo -e "\n[\033[1;31mERROR\033[0m] 'which_python_version.bash' script must be sourced from the 'utility_scripts/'!\n Curent working directory is '$(pwd)'" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -33,7 +33,7 @@ if [[ -z $PROJECT_PROMPT_NAME ]] && [[ -z $PROJECT_GIT_NAME ]] ; then
   set +o allexport
 fi
 
-cd ../function_library || exit
+cd ../function_library || exit 1
 source ./general_utilities.bash
 
 cd "${TMP_CWD}"

tests/bats_testing_tools/bats_helper_functions.bash

@@ -37,7 +37,7 @@ function mock_docker_command_exit_ok() {
 
 function mock_docker_command_exit_error() {
     function docker() {
-      echo "Error" >&2
+      echo "Error" 1>&2
       return 1
     }
 }

tests/bats_testing_tools/run_bats_tests_in_docker.bash

@@ -32,7 +32,7 @@ N2ST_BATS_TESTING_TOOLS_ABS_PATH="$( cd "$( dirname "${0}" )" &> /dev/null && pw
 N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH=".${N2ST_BATS_TESTING_TOOLS_ABS_PATH/$REPO_ROOT/}"
 
 if [[ $(basename "$REPO_ROOT") != ${PROJECT_CLONE_GIT_NAME} ]]; then
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 must be executed from the project root!\nCurrent wordir: $(pwd)"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 must be executed from the project root!\nCurrent wordir: $(pwd)" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1

tests/test_docker_utilities.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -45,7 +45,7 @@ setup_file() {
 
 setup() {
   source .env.project
-  cd $TESTED_FILE_PATH || exit
+  cd $TESTED_FILE_PATH || exit 1
   source ./$TESTED_FILE
 
 }

tests/test_dotenv_files.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1

tests/test_general_utilities.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -44,7 +44,7 @@ setup_file() {
 
 setup() {
   source .env.project
-  cd $TESTED_FILE_PATH || exit
+  cd $TESTED_FILE_PATH || exit 1
   source ./$TESTED_FILE
 }
 

tests/test_import_lib.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -48,7 +48,7 @@ setup_file() {
 
 # executed before each test
 setup() {
-  cd "$TESTED_FILE_PATH" || exit
+  cd "$TESTED_FILE_PATH" || exit 1
 }
 
 # ====Teardown=====================================================================================

tests/test_install_docker_tools.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -44,7 +44,7 @@ setup_file() {
 }
 
 setup() {
-  cd "$TESTED_FILE_PATH" || exit
+  cd "$TESTED_FILE_PATH" || exit 1
 }
 
 # ====Teardown=====================================================================================

tests/test_prompt_utilities.bats

@@ -26,7 +26,7 @@ if [[ -d ${BATS_HELPER_PATH} ]]; then
   load "${SRC_CODE_PATH}/${N2ST_BATS_TESTING_TOOLS_RELATIVE_PATH}/bats_helper_functions"
   #load "${BATS_HELPER_PATH}/bats-detik/load" # << Kubernetes support
 else
-  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!"
+  echo -e "\n[\033[1;31mERROR\033[0m] $0 path to bats-core helper library unreachable at \"${BATS_HELPER_PATH}\"!" 1>&2
   echo '(press any key to exit)'
   read -r -n 1
   exit 1
@@ -43,7 +43,7 @@ setup_file() {
 
 setup() {
   source .env.project
-  cd "src/function_library" || exit
+  cd "src/function_library" || exit 1
   source ./$TESTED_FILE
   TEST_TEMP_DIR="$(temp_make)"
 }

tests/test_teamcity_utilities.bats

@@ -44,7 +44,7 @@ setup_file() {
 
 setup() {
   source .env.project
-  cd $TESTED_FILE_PATH || exit
+  cd $TESTED_FILE_PATH || exit 1
   source ./$TESTED_FILE
 }
 

tests/test_terminal_splash.bats

@@ -41,7 +41,7 @@ setup_file() {
 }
 
 setup() {
-  cd "src/function_library" || exit
+  cd "src/function_library" || exit 1
   source ./terminal_splash.bash
 }
 

tests/test_which_architecture_and_os.bats

@@ -44,7 +44,7 @@ setup_file() {
 }
 
 setup() {
-  cd "$TESTED_FILE_PATH" || exit
+  cd "$TESTED_FILE_PATH" || exit 1
 }
 
 # ====Teardown=====================================================================================

tests/test_which_python_version.bats

@@ -44,7 +44,7 @@ setup_file() {
 }
 
 setup() {
-  cd "$TESTED_FILE_PATH" || exit
+  cd "$TESTED_FILE_PATH" || exit 1
 }
 
 # ====Teardown=====================================================================================

tests/tests_template/test_template.bats

@@ -49,7 +49,7 @@ setup_file() {
 
 # executed before each test
 setup() {
-  cd "$TESTED_FILE_PATH" || exit
+  cd "$TESTED_FILE_PATH" || exit 1
   source ./$TESTED_FILE
 }