fork tests on other chains + fork test bug fix #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
commented
Nov 29, 2022
| @@ -7,7 +7,7 @@ import {NomadTest} from "@nomad-xyz/contracts-core/contracts/test/utils/NomadTes | |||
|
|
|||
| contract RebootTest is RebootLogic, NomadTest { | |||
| string remote; | |||
| string constant _domain = "ethereum"; | |||
| string constant testDomain = "ethereum"; | |||
|
|
|||
| function setUpReboot(string memory testName) public { | |||
| // ALL | |||
There was a problem hiding this comment.
we could get RPC from config instead of .env, that would make it easier to switch between chains quickly, but the config RPC situation is grim because those are all public endpoints that are usually quite frail
There was a problem hiding this comment.
additionally, we could remove the pinned block number in order to make it more seamlessly compatible with all chains, but then the tests wouldn't cache the block which would make them even slower
There was a problem hiding this comment.
don't get RPC from config, we don't want to keep good RPCs in those
anna-carroll
changed the title
anna-carroll
changed the title
prestwich
requested changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist