Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration DI in sdk-bridge (discussion) #284

Open
khcd opened this issue May 16, 2022 · 0 comments
Open

fix: configuration DI in sdk-bridge (discussion) #284

khcd opened this issue May 16, 2022 · 0 comments

Comments

@khcd
Copy link

khcd commented May 16, 2022

Currently experiencing wasm issues due to configuration wasm being a second order dependency of sdk bridge package.

allow https://github.com/nomad-xyz/rust/tree/main/configuration/src to be injected as a dependency via constructor or other means

currently:

const nomadSDK = await import("@nomad-xyz/sdk-bridge");
const nomad = new nomadSDK.BridgeContext("development");

proposed:

const nomadSDK = await import("@nomad-xyz/sdk-bridge");
import * as configuration from "@nomad-xyz/configuration";
const nomad = new nomadSDK.BridgeContext(configuration.getBuiltin("development"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant