Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in error string #46

Open
giorgionocera opened this issue Feb 8, 2024 · 0 comments
Open

Typo in error string #46

giorgionocera opened this issue Feb 8, 2024 · 0 comments

Comments

@giorgionocera
Copy link

Hi there,
it seems that during the 4c6c593 commit, this error message was not adapted.

.ok_or_else(|| String::from("Total weight is greater than maximum value of u32"))?;

The function works also with values that sums to u128:MAX, so x | 0 ≤ x ≤ u128 => x ≥ u32 is fine.

It is only an error message, but I'm preparing a PR for this.

giorgionocera added a commit to nabla-studio/nois that referenced this issue Feb 8, 2024
Fixing a typo in error string returned by select_from_weighted method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant