Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording of SDX readme. #41

Open
feamster opened this issue Jul 10, 2015 · 2 comments
Open

Improve wording of SDX readme. #41

feamster opened this issue Jul 10, 2015 · 2 comments

Comments

@feamster
Copy link
Member

There are a few things which could be worded better in HW7.

  1. "First, you will configure the topology as shown in the figure. You will need two files:"
    There are more than "two files" which need to be edited. Saying there are only two files of interest is misleading. Also you might want to say "you will need to edit" not just "you will need"

$ sudo sh clean.sh
The instructions don't mention where to find it, it is not in the path, nor is it in the working directories in the home directory. Perhaps change it to:
sudo sh /vagrant/assignments/sdn-ixp/clean.sh

  1. The policy section talks about HTTP and HTTPS. You do show examples of testing with port 80.
    But you don't mention port 443 (default HTTPS port) ANYWHERE in the document. Nor do you mention port 4321 ANYWHERE in the Assignment section. I think maybe you want us to continue working with port 4321? But if so, then why are you referring to HTTPS and not port 4321? Hmm. Maybe you really mean HTTP and HTTPS like you say. Then perhaps, simply add one more line that makes it clear that we can remove any references to port 4321 and port 4322 in the existing files.
    I do see that submit.py only tests port 80, so it isn't very concerned either way with the other ports, but it would be nice if the instructions were easier to interpret the intent.
@feamster
Copy link
Member Author

Also, there's an error in the readme that has students run pyretic.py in the background. We should remove the "&".

@sairammohandass
Copy link

I would like to work on this issue can you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants