Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a traffic manager I would like to integrate "traffic events" of the regional roads in the Province of Bolzano in the Open Data Hub #307

Closed
rcavaliere opened this issue Nov 20, 2021 · 12 comments
Assignees

Comments

@rcavaliere
Copy link
Member

rcavaliere commented Nov 20, 2021

It deals with the integration of this PR: #306

It depends on #263 since it needs the extension for integrating events type

@Piiit
Copy link
Contributor

Piiit commented Apr 15, 2022

@rcavaliere I think we can close this, right?

@rcavaliere
Copy link
Member Author

@Piiit did you integrate the DC in testing environment (see above linked PR)?

@Piiit
Copy link
Contributor

Piiit commented Apr 19, 2022

The related PR was automatically closed by Github, I will integrate it now (indirectly by myself, because I renamed a git branch)

@Piiit
Copy link
Contributor

Piiit commented Apr 19, 2022

@rcavaliere The DC has only a event-uuid, but misses the event-series unique identifier...

The event UUID is composed of:

  • beginDate
  • endDate
  • messageId
  • messageTypeId
  • X
  • Y

Should I build the event-series-uuid with these fields?

  • messageId
  • messageTypeId

@rcavaliere
Copy link
Member Author

@Piiit sorry I did not understand. We miss some fields to generate the event UUID, correct? In this case can't we use just these 4 fields to generate the UUID?

@Piiit
Copy link
Contributor

Piiit commented Apr 20, 2022

we have two UUIDs here, one for the event itself and one for the event-series... since the second did not exist when the DC has been written, I ask, which fields form a single event, and which fields should be used to form an identifier for series of events? If this DC has only single events and no series, we can just use the same UUID (of all six fields) for event-uuid and event-series-uuid

@Piiit
Copy link
Contributor

Piiit commented Apr 20, 2022

In this case can't we use just these 4 fields to generate the UUID?

The source code uses all 6 fields at the moment, which should I take out?

@Piiit
Copy link
Contributor

Piiit commented Apr 20, 2022

@rcavaliere The date interval seems to be wrong, I check that now

@Piiit
Copy link
Contributor

Piiit commented Apr 20, 2022

@rcavaliere
Copy link
Member Author

@Piiit ok let me test it in the next days...

@Piiit
Copy link
Contributor

Piiit commented Apr 20, 2022

@rcavaliere Perfect, the date issues are solved now

@rcavaliere
Copy link
Member Author

@Piiit I have tested the DC. I have the following open points:

  • description is expected to be a string providing more details about the event (formatted as "description_IT | description_DE")
  • event_interval is not properly formatted (e.g. "["2022-04-20 00:00:00",)") -> please just use "[ ]" or "( )". I have seen that in some cases the information of the event end date ("evend") is not available - if not provided, I would expect to always receive this value but to have something like evend = ""
  • what information is stored in our field "name" (I see a number at the moment...)?

I have already reported these points to @noctho. Please let me know, once checked / solved we can put the Data Collector in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants