Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old graph:error messages reappears on successful commands #869

Open
jonnor opened this issue Apr 16, 2018 · 1 comment
Open

Old graph:error messages reappears on successful commands #869

jonnor opened this issue Apr 16, 2018 · 1 comment

Comments

@jonnor
Copy link
Member

jonnor commented Apr 16, 2018

Cause an FBP protocol error to happen. In this case through an unparseable data as an IIP

FBP MICROFLO RECV: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '440' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '440' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main' } }
FBP MICROFLO RECV: { protocol: 'graph',
  command: 'addinitial',
  payload: 
   { src: { data: '!' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'error',
  payload: 
   { message: 'Unknown IIP data type for literal \'!\' :SyntaxError: Unexpected token ! in JSON at position 0' } }

This gives the error to user, which is good.

However, when doing other graph actions later that should succeed, the error appears again.
Like changing the invalid value to a valid 1 and then a 2.

FBP MICROFLO RECV: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '!' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '!' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main' } }
FBP MICROFLO RECV: { protocol: 'graph',
  command: 'addinitial',
  payload: 
   { src: { data: '1' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
queuing buf <Buffer 0d 02 00 07 01 00 00 00> 0 8 false
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'addinitial',
  payload: 
   { src: { data: '1' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main' } }
MICROFLO SEND: 40 <Buffer 0d 02 00 07 01 00 00 00> null undefined false
MICROFLO RECV: 8 <Buffer 72 02 00 07 00 00 00 00>
FBP MICROFLO SEND: { protocol: 'runtime',
  command: 'packetsent',
  payload: 
   { port: 'sssss',
     event: 'data',
     type: 'any',
     graph: 'main',
     payload: {} } }



FBP MICROFLO RECV: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '1' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'removeinitial',
  payload: 
   { src: { data: '1' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main' } }
FBP MICROFLO RECV: { protocol: 'graph',
  command: 'addinitial',
  payload: 
   { src: { data: '2' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main',
     secret: '' } }
queuing buf <Buffer 0d 02 00 07 02 00 00 00> 0 8 false
FBP MICROFLO SEND: { protocol: 'graph',
  command: 'addinitial',
  payload: 
   { src: { data: '2' },
     tgt: { node: 'Timer_jrwr3', port: 'interval' },
     graph: 'main' } }
MICROFLO SEND: 40 <Buffer 0d 02 00 07 02 00 00 00> null undefined false
MICROFLO RECV: 8 <Buffer 72 02 00 07 00 00 00 00>
FBP MICROFLO SEND: { protocol: 'runtime',
  command: 'packetsent',
  payload: 
   { port: 'sssss',
     event: 'data',
     type: 'any',
     graph: 'main',
     payload: {} } }
@jonnor jonnor changed the title Old graph:error messages reappears after successful messages Old graph:error messages reappears after successful commands Apr 16, 2018
@jonnor jonnor changed the title Old graph:error messages reappears after successful commands Old graph:error messages reappears on successful commands Apr 16, 2018
@jonnor
Copy link
Member Author

jonnor commented Apr 16, 2018

Note, to reproduce as described need MicroFlo with microflo/microflo#181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant