Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/export runtime information from graph JSON #487

Open
th0br0 opened this issue Aug 10, 2015 · 8 comments
Open

Import/export runtime information from graph JSON #487

th0br0 opened this issue Aug 10, 2015 · 8 comments

Comments

@th0br0
Copy link

th0br0 commented Aug 10, 2015

Runtime information can be imported from gists (i.e. https://gist.github.com/th0br0/c906d736ae732190c46e), however, it is not serialised when manually exporting a graph.

Is this intended behaviour?

@jonnor
Copy link
Member

jonnor commented Aug 10, 2015

Is everything under properties top-level key missing?
Does this happen only when the graph was imported from gist, or also for graphs created manually?

It is probably not intended behavior.

@th0br0
Copy link
Author

th0br0 commented Aug 10, 2015

properties is populated as follows for a manually created graph. It might be related to #488 though.

 "properties": {
        "name": "main",
        "id": "test/main",
        "project": "test",
        "environment": {
            "type": "noflo-browser"
        },
        "changed": true
    },

@jonnor
Copy link
Member

jonnor commented Aug 10, 2015

And when importing from a gist it looks like?

@th0br0
Copy link
Author

th0br0 commented Aug 10, 2015

Assuming that

    "properties": {
        "name": "ttttt",
        "environment": {
            "type": "noflo-browser",
            "protocol": "iframe",
            "address": "http://th0kus.ngrok.io/everything.html"
        }
    },

is a valid header properties header for an imported gist, it'd seem that my tests earlier got a bit screwed up. It seems that the runtime isn't imported from the gist at all!?

@jonnor
Copy link
Member

jonnor commented Aug 10, 2015

I don't think protocol and address are recognized attributes under environment? But it would be very useful to have something to allow specifying custom runtime in graph. CC @bergie

@th0br0
Copy link
Author

th0br0 commented Aug 10, 2015

Well, I tried out various combinations, including {"type":"html","src":"http://...","protocol":"iframe"} to no avail. And the official graph-schema.json doesn't specifcy the properties contents... where'd be a better place to look?

@jonnor
Copy link
Member

jonnor commented Aug 10, 2015

There is probably no place better :) We should update it!

Anyway, rephrasing the issue as an enhancement request to load runtime information (protocol, address) from imported graphs (at least gists), and to export the information to .json. Do you agree with that?

@th0br0
Copy link
Author

th0br0 commented Aug 10, 2015

Yes - that'd be awesome!

On Mon, Aug 10, 2015 at 1:12 PM, Jon Nordby [email protected]
wrote:

There is probably no place better :) We should update it!

Anyway, rephrasing the issue as an enhancement request to load runtime
information (protocol, address) from imported graphs (at least gists), and
to export the information to .json. Do you agree with that?


Reply to this email directly or view it on GitHub
#487 (comment).

@jonnor jonnor changed the title Serialise runtime information to exported graph Import/export runtime information from graphs Aug 10, 2015
@jonnor jonnor changed the title Import/export runtime information from graphs Import/export runtime information from graph JSON Aug 10, 2015
@bergie bergie added the runtime label Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants