Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move History module out to mapview #2

Open
relrod opened this issue May 12, 2016 · 0 comments
Open

Move History module out to mapview #2

relrod opened this issue May 12, 2016 · 0 comments

Comments

@relrod
Copy link
Member

relrod commented May 12, 2016

We should "upstream" the History flight module because it is probably useful outside of noexc flights and also makes it easier to document how to set up mapview-websocket in a sensible way (i.e., most implementations will probably want historic data sent to new websocket connections and right now that is a manual process for all implementations. Moving this to mapview would turn that into "Add a callback to your MapviewConfig and add a callback to where you initialize the websocket server" and everything else would "just work".

The only issue is that this assumes a sensible ToJSON instance for the parsed packet type (I have a document started on what "sensible" means here -- we'll have to provide a specification at least for our own frontend; of course other frontends could require different things). If other frontends require different formats and we want to be able to use all of them at once, then that is an issue, but I think we should worry about that later on. We already have this issue after noexc/mapview@a660e33 anyway.

(The usual solution here is to newtype but then we couldn't use the normal callbacks in MapviewConfig anymore because the newtyped types would no longer match our t).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant