Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 15.2.0 and unknown props #25

Closed
vdh opened this issue Jul 4, 2016 · 3 comments · Fixed by #26
Closed

React 15.2.0 and unknown props #25

vdh opened this issue Jul 4, 2016 · 3 comments · Fixed by #26

Comments

@vdh
Copy link
Contributor

vdh commented Jul 4, 2016

React 15.2 added some (rather obtuse) warning messages about unknown props:

Warning: Unknown props `autoshow`, `forceGemini` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by GeminiScrollbar)
@vdh
Copy link
Contributor Author

vdh commented Jul 6, 2016

@noeldelgado I didn't make any changes in #26 to dist/index.js, I only touched src/index.jsx, so it'll need a rebuild.

@noeldelgado
Copy link
Owner

@vdh, are you sure? I didn't test it, but I checked the build and didn't find any reference to autoshow or forceGemini on the render method. I will make a quick test though.

@vdh
Copy link
Contributor Author

vdh commented Jul 6, 2016

@noeldelgado I created #27 to rebuild the fix into dist/index.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants