Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs off of https://nodejs.org/en/download/package-manager/all all 404 #7062

Open
bmuenzenmeyer opened this issue Sep 27, 2024 · 6 comments
Open
Labels

Comments

@bmuenzenmeyer
Copy link
Collaborator

URL:

https://nodejs.org/en/download/package-manager/all

Browser Name:

Chrome

Browser Version:

128.0.6613.138

Operating System:

Windows

How to reproduce the issue:

  1. Go to https://nodejs.org/en/download/package-manager
  2. Click on package managers on the bottom of the page
  3. Land on https://nodejs.org/en/download/package-manager/all
  4. Click on Prebuilt Installer, Prebuilt binaries, or Source Code

All tabs except the default 404

@mikeesto
Copy link
Member

I'm wondering whether we even need the tabs on https://nodejs.org/en/download/package-manager/all

@Nyx1on
Copy link
Contributor

Nyx1on commented Sep 29, 2024

I think it's better to hide all the tabs from https://nodejs.org/en/download/package-manager/all

@ovflowd
Copy link
Member

ovflowd commented Sep 30, 2024

Why are the tabs even there? This was not the case in the past? Did someone change the layouts recently?

@canerakdas
Copy link
Member

IMHO this page should not be in the downloads directory, it looks more like a content page that should be under the learn.

If we want to use a different layout in the download directory, this PR actually solves this issue; #6929

@ovflowd
Copy link
Member

ovflowd commented Sep 30, 2024

IMHO this page should not be in the downloads directory, it looks more like a content page that should be under the learn.

If we want to use a different layout in the download directory, this PR actually solves this issue; #6929

I assume this page eventually will go away with the redesign of the downloads page; I don't think it should reside under learn... It is not a learn page, but a download page.

@canerakdas
Copy link
Member

canerakdas commented Sep 30, 2024

IMHO this page should not be in the downloads directory, it looks more like a content page that should be under the learn.
If we want to use a different layout in the download directory, this PR actually solves this issue; #6929

I assume this page eventually will go away with the redesign of the downloads page; I don't think it should reside under learn... It is not a learn page, but a download page.

I think it's a nice feature to be able to see other download options while on a download page, but I can't defend it since this page will be completely changed soon 😄 I think we can move on with this PR; #6929

Here is the preview; https://nodejs-1gq1n4ies-openjs.vercel.app/en/download/package-manager/all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants