Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-http-max-sockets fails in node-test-binary-windows-js-suites #47116

Closed
tniessen opened this issue Mar 16, 2023 · 11 comments · Fixed by #54976
Closed

test-http-max-sockets fails in node-test-binary-windows-js-suites #47116

tniessen opened this issue Mar 16, 2023 · 11 comments · Fixed by #54976
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform.

Comments

@tniessen
Copy link
Member

tniessen commented Mar 16, 2023

Test

test-http-max-sockets

Platform

Windows

Console output

Socket: 1/10 queued: 0
Socket: 2/10 queued: 0
Socket: 3/10 queued: 0
Socket: 4/10 queued: 0
Socket: 5/10 queued: 0
Socket: 6/10 queued: 0
Socket: 7/10 queued: 0
Socket: 8/10 queued: 0
Socket: 9/10 queued: 0
Socket: 10/10 queued: 0
Socket: 10/10 queued: 1
Socket: 10/10 queued: 2
Socket: 10/10 queued: 3
Socket: 10/10 queued: 4
Socket: 10/10 queued: 5
Socket: 10/10 queued: 6
Socket: 10/10 queued: 7
Socket: 10/10 queued: 8
Socket: 10/10 queued: 9
Socket: 10/10 queued: 10

Build links

(Many recent Windows builds.)

Additional information

Build trend:

build trend showing recent failures

Refs: #47091 (comment)

cc @nodejs/http @nodejs/platform-windows

@tniessen tniessen added http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 16, 2023
@mcollina
Copy link
Member

Ouch! Should we skip on that platform?

cc @ShogunPanda

@tniessen
Copy link
Member Author

I don't know why it only started failing (frequently) recently. I don't see any related changes in the commit history.

@mcollina
Copy link
Member

Where do we source our Windows machines? I've seen a significant degradation in performance for GitHub Actions on Windows (which uses Azure), leading to many of my project to start failing on Windows.

My 2 cents is something has changed on the host and the test is now flaky enough to be a problem (while before it failed spuriously)

@tniessen
Copy link
Member Author

cc @nodejs/build

@tniessen
Copy link
Member Author

Marking it: #47134

@targos
Copy link
Member

targos commented Mar 17, 2023

Azure and Rackspace (~50%/50%)

@targos
Copy link
Member

targos commented Mar 17, 2023

The three failures linked by @tniessen happened on Rackspace machines

@tniessen
Copy link
Member Author

@targos Almost all recent builds have failed. Are all of these on rackspace?

@targos
Copy link
Member

targos commented Mar 17, 2023

I don't know how to check without opening each run one by one.

@tniessen
Copy link
Member Author

I don't expect you to do that, of course 😄 And I assume that we couldn't do anything about it even if it was rackspace machines, so let's go ahead with marking it as flaky (or skip if necessary) for now.

nodejs-github-bot pushed a commit that referenced this issue Mar 17, 2023
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
targos pushed a commit that referenced this issue Mar 18, 2023
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@tniessen
Copy link
Member Author

According to nodejs/reliability#527 and nodejs/reliability#526, the test did indeed only fail on Rackspace machines. However, given the build trend (see #47116 (comment)), that would mean that Rackspace picked up almost every build.

danielleadams pushed a commit that referenced this issue Jul 6, 2023
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
lpinca added a commit to lpinca/node that referenced this issue Sep 17, 2024
There is no recent trace of failure for this test.

Fixes: nodejs#47116
targos pushed a commit that referenced this issue Oct 4, 2024
There is no recent trace of failure for this test.

Fixes: #47116
PR-URL: #54976
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
There is no recent trace of failure for this test.

Fixes: nodejs#47116
PR-URL: nodejs#54976
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants