-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-http-max-sockets fails in node-test-binary-windows-js-suites #47116
Comments
Ouch! Should we skip on that platform? cc @ShogunPanda |
I don't know why it only started failing (frequently) recently. I don't see any related changes in the commit history. |
Where do we source our Windows machines? I've seen a significant degradation in performance for GitHub Actions on Windows (which uses Azure), leading to many of my project to start failing on Windows. My 2 cents is something has changed on the host and the test is now flaky enough to be a problem (while before it failed spuriously) |
cc @nodejs/build |
Marking it: #47134 |
Azure and Rackspace (~50%/50%) |
The three failures linked by @tniessen happened on Rackspace machines |
@targos Almost all recent builds have failed. Are all of these on rackspace? |
I don't know how to check without opening each run one by one. |
I don't expect you to do that, of course 😄 And I assume that we couldn't do anything about it even if it was rackspace machines, so let's go ahead with marking it as flaky (or skip if necessary) for now. |
Refs: #47116 PR-URL: #47134 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Refs: #47116 PR-URL: #47134 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
According to nodejs/reliability#527 and nodejs/reliability#526, the test did indeed only fail on Rackspace machines. However, given the build trend (see #47116 (comment)), that would mean that Rackspace picked up almost every build. |
Refs: #47116 PR-URL: #47134 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
There is no recent trace of failure for this test. Fixes: nodejs#47116
There is no recent trace of failure for this test. Fixes: #47116 PR-URL: #54976 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
There is no recent trace of failure for this test. Fixes: nodejs#47116 PR-URL: nodejs#54976 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Test
test-http-max-sockets
Platform
Windows
Console output
Build links
(Many recent Windows builds.)
Additional information
Build trend:
Refs: #47091 (comment)
cc @nodejs/http @nodejs/platform-windows
The text was updated successfully, but these errors were encountered: