Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum macOS version #53561

Open
anonrig opened this issue Jun 23, 2024 · 4 comments
Open

Increase minimum macOS version #53561

anonrig opened this issue Jun 23, 2024 · 4 comments
Labels
build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX.

Comments

@anonrig
Copy link
Member

anonrig commented Jun 23, 2024

std::format("hello {}", "world") is not available before 13.3, and we support 11. Is there any reason not to update minimum macOS version in the next major?

  • macOS 11 release date -> 2020
  • macOS 13 release date -> 2022
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/formatter_floating_point.h:73:32: error: 'to_chars' is unavailable: introduced in macOS 13.3
  to_chars_result __r = _VSTD::to_chars(__first, __last, __value, __fmt, __precision);
../../src/node_file.cc:2159:25: note: in instantiation of function template specialization 'std::format<char *>' requested here
    auto message = std::format("src and dest cannot be the same %s", src.out());

cc @nodejs/build @nodejs/tsc

@tniessen
Copy link
Member

For me as a non-macOS user, is this about the macOS system version or about the compiler/toolchain version? And if it's the system version, is it only about the build environment or about the target environment?

@richardlau
Copy link
Member

Semi-related Build WG issue tracking macOS CI resources: nodejs/build#3686

@richardlau richardlau added the macos Issues and PRs related to the macOS platform / OSX. label Jun 23, 2024
@anonrig
Copy link
Member Author

anonrig commented Jun 29, 2024

I feel like it is a build environment requirement. How can I verify? @tniessen

@anonrig anonrig added the build Issues and PRs related to build files or the CI. label Jun 29, 2024
@targos
Copy link
Member

targos commented Jun 30, 2024

Try to change:

'MACOSX_DEPLOYMENT_TARGET': '11.0', # -mmacosx-version-min=11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants