From 33f31fe2dae1e0865f856b1fd53492bbb9fb8814 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Mon, 4 Nov 2024 02:27:07 -0500
Subject: [PATCH] lib: avoid excluding symlinks in recursive fs.readdir with
 filetypes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes: https://github.com/nodejs/node/issues/52663
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
---
 lib/fs.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/fs.js b/lib/fs.js
index 9db60a4f89a3d9..38f5fe9d468a8c 100644
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -1401,9 +1401,12 @@ function readdirSyncRecursive(basePath, options) {
       // of the first array within the result.
       const length = readdirResult[0].length;
       for (let i = 0; i < length; i++) {
+        // Avoid excluding symlinks, as they are not directories.
+        // Refs: https://github.com/nodejs/node/issues/52663
+        const stat = binding.internalModuleStat(binding, pathModule.join(path, readdirResult[0][i]));
         const dirent = getDirent(path, readdirResult[0][i], readdirResult[1][i]);
         ArrayPrototypePush(readdirResults, dirent);
-        if (dirent.isDirectory()) {
+        if (dirent.isDirectory() || stat === 1) {
           ArrayPrototypePush(pathsQueue, pathModule.join(dirent.parentPath, dirent.name));
         }
       }