From ee1fdbfeabe07b84db4742ab48c35f9492e865e4 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Tue, 24 Sep 2024 10:17:59 +0200 Subject: [PATCH] fix(git-node): ignore all non-gha nodes when checking for GitHub CI --- lib/pr_checker.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index b37314e4..064c647c 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -29,7 +29,6 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED']; const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/; const FAST_TRACK_MIN_APPROVALS = 2; const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork'; -const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov']; // eslint-disable-next-line no-extend-native Array.prototype.findLastIndex ??= function findLastIndex(fn) { @@ -374,9 +373,10 @@ export default class PRChecker { // GitHub new Check API for (const { status, conclusion, app } of checkSuites.nodes) { - if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { + if (app.slug !== 'github-actions') { // Ignore Dependabot and Codecov check suites. - // They are expected to show up sometimes and never complete. + // They are expected to show up on PRs whose head branch is not on a + // fork and never complete. continue; }