From 621ea62d016c885555e34f7ff75a95258c33d739 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:12:15 +0200 Subject: [PATCH 1/6] GitHub Action to run tests on current versions of Node.js --- .github/workflows/ci.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..a07f28d4 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,23 @@ +# Tests are also run at: https://ci.appveyor.com/project/RodVagg/nan +# https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs + +name: ci +on: + push: + branches: [master] + pull_request: + branches: [master] +jobs: + ci: + strategy: + matrix: + node-version: [18.x, 20.x] + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + - run: npm ci + - run: npm run build --if-present + - run: npm test From 1ef391bd63dc77f5dec569a1752f43cdecfb09a3 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:13:12 +0200 Subject: [PATCH 2/6] GitHub Action to run tests on current versions of Node.js --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a07f28d4..91abeec9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,9 +4,9 @@ name: ci on: push: - branches: [master] + branches: [main] pull_request: - branches: [master] + branches: [main] jobs: ci: strategy: From 38557ecab93daf0011bbd25c0a3d8ae469249762 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:14:46 +0200 Subject: [PATCH 3/6] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 91abeec9..70df6115 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ name: ci on: push: - branches: [main] + # branches: [main] pull_request: branches: [main] jobs: From 1f00235552afec1d3e29f201d10769c83420a14a Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:17:24 +0200 Subject: [PATCH 4/6] Update ci.yml --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 70df6115..1fe8a424 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,6 +18,7 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - - run: npm ci + # - run: npm ci + - run: npm install - run: npm run build --if-present - run: npm test From 6ecc3a30260f4b1307eb64ed42ea584284e580f6 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:23:47 +0200 Subject: [PATCH 5/6] Update ci.yml --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1fe8a424..b5ddf1ed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,5 +20,7 @@ jobs: node-version: ${{ matrix.node-version }} # - run: npm ci - run: npm install - - run: npm run build --if-present - - run: npm test + # - run: npm run build --if-present + - run: npm run rebuild-tests-2017 + # - run: npm test + - run: node node_modules\tap\bin\tap.js --gc test/js/*-test.js From 976e41dba42f9d17481601a7ae9850b779435b08 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 29 Sep 2023 15:33:13 +0200 Subject: [PATCH 6/6] Update ci.yml --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b5ddf1ed..d2d6167f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,7 @@ on: jobs: ci: strategy: + fail-fast: false matrix: node-version: [18.x, 20.x] runs-on: ubuntu-latest @@ -23,4 +24,4 @@ jobs: # - run: npm run build --if-present - run: npm run rebuild-tests-2017 # - run: npm test - - run: node node_modules\tap\bin\tap.js --gc test/js/*-test.js + - run: node node_modules/tap/bin/tap.js --gc test/js/*-test.js