Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Making it easier to build it for OpenIndiana #307

Open
rtvd opened this issue May 18, 2016 · 1 comment
Open

Making it easier to build it for OpenIndiana #307

rtvd opened this issue May 18, 2016 · 1 comment

Comments

@rtvd
Copy link

rtvd commented May 18, 2016

Hello,

I tried packaging this library for OpenIndiana.
Would it be possible for you to have the following changes to the Makefile?

  1. Change LIBDIR = $(PREFIX)/lib to LIBDIR ?= $(PREFIX)/lib so that LIBDIR could be re-defined externally.
  2. Change both lines ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT) to ln -s $(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT) so that relative paths are used for symbolic links.

Thank you.

AdamMajer added a commit to AdamMajer/http-parser that referenced this issue Dec 1, 2016
@roman-neuhauser
Copy link

LIBDIR and INCLUDEDIR are overridable w/o any change: make LIBDIR=foo INCLUDEDIR=bar. = gives precedence to make's operands, ?= gives precedence to operands and environment.

i support the second point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants