Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: use test: symbol on second print of parent test #54956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test_runner: use test: symbol on second print of parent test #54956

wants to merge 1 commit into from
+6 −8

Conversation

RedYetiDev
Copy link
Member

Fixes nodejs/help#4482

Before | After

image

While the first report of a test with subtests is a ▶ character, this PR updates the second report to be a ✔ or ✖, indicating the actual success of the test, without the need for colorization.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 15, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (c77bcf0) to head (6d5ed1d).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54956      +/-   ##
==========================================
- Coverage   88.07%   88.07%   -0.01%     
==========================================
  Files         652      652              
  Lines      183570   183568       -2     
  Branches    35872    35868       -4     
==========================================
- Hits       161686   161677       -9     
+ Misses      15137    15135       -2     
- Partials     6747     6756       +9
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/utils.js 96.70% <100.00%> (-0.08%) ⬇️

... and 33 files with indirect coverage changes

MoLow
MoLow approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change LGTM, but I am not sure if this is breaking or not

@RedYetiDev RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62509/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2024
@RedYetiDev RedYetiDev mentioned this pull request Sep 18, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtests cause the parent test to stop showing up as green even if it asserts.
3 participants
@RedYetiDev @nodejs-github-bot @MoLow