Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diag WG Meeting - 2017-01-19 #79

Closed
joshgav opened this issue Jan 12, 2017 · 18 comments
Closed

Diag WG Meeting - 2017-01-19 #79

joshgav opened this issue Jan 12, 2017 · 18 comments

Comments

@joshgav
Copy link
Contributor

joshgav commented Jan 12, 2017

Date/Time

Thursday Jan 19 2000 UTC (12pm US Pacific)

It's helpful if you give this post a 👍 or 👎 so we know you'll be attending. Thanks!

Join/Watch

If you are only observing please use the YouTube channel; Hangouts limits the number of connections.

Minutes

Agenda

Inspector

Trace

Async Context

Post-Mortem


/cc @nodejs/diagnostics @nodejs/post-mortem

@joshgav
Copy link
Contributor Author

joshgav commented Jan 12, 2017

Will fill in the agenda with relevant issues from this and other repos. Please suggest more in this thread.

Everyone please fill in the Doodle by end of week (1/13) so we can settle on a time.

@mhdawson @yunong @rnchamberlain @richardlau - would it be worth discussing topics from the nodejs/post-mortem repo in the Diagnostics meetings too? For me at least I try to stay deeply on top of both :)

@mhdawson
Copy link
Member

mhdawson commented Jan 12, 2017

I won't be able to make it the week of Jan 16-20 as I'm off on holiday.

@rnchamberlain
Copy link

@joshgav yes it would be good to discuss some of the post mortem work if there is time in your meeting, doodle poll updated, thanks

@joshgav
Copy link
Contributor Author

joshgav commented Jan 14, 2017

@mhdawson are you asking us to defer for a week? Otherwise, I think Thursday at 2000 UTC (12pm Pacific) works for everyone, so I updated the OP accordingly.

I also added a number of issues to the agenda from here and nodejs/node, we can trim if some can simply continue progressing through discussion in GitHub. If you'd like to add others please comment here or edit the OP if you prefer.

Thanks!

@joshgav joshgav changed the title Diag WG Meeting - 2017-01 Diag WG Meeting - 2017-01-19 Jan 14, 2017
@watson
Copy link
Member

watson commented Jan 15, 2017

I'm going to NodeConf Budapest on the 19th unfortunately, so I don't think I can make it 😞
I updated the description to say you should 👎 if you can't make it so @joshgav knows if people have seen it

@joshgav
Copy link
Contributor Author

joshgav commented Jan 19, 2017

Reminder that we're scheduled to meet tomorrow (Thursday 1/19) at 12pm US Pacific, 2000 UTC. See you then!

@AndreasMadsen
Copy link
Member

AsyncHooks is such a minor part of todays agenda that I'm not going to join.


A short update on async_hooks (it is actually all I know)

A while ago Trevor said the following where missing:

  • Remove all weak objects (will be handled in another PR to solve another issue)
  • Add support to node::MakeCallback
  • Implement public native API.
  • Detect a change in the hooks queue when in the middle of running hooks, so the original set of hooks can finish executing.

My best guess is that only "Add support to node::MakeCallback" and "Implement public native API" is missing now, but that he want to test the current implement first.

@richardlau
Copy link
Member

Apologies, this is my first time using Hangouts. I'm getting a 403 error trying to access the participate link in the description.

@rnchamberlain
Copy link

me too

@joshgav
Copy link
Contributor Author

joshgav commented Jan 19, 2017

Thanks, working on it now. Perhaps you need to be signed in to a Google account? We're testing here in the MS office too.

@joshgav
Copy link
Contributor Author

joshgav commented Jan 19, 2017

Confirmed that you need to be signed into a Google account. Can you try that?

@rnchamberlain
Copy link

rnchamberlain commented Jan 19, 2017

I'm signed in - mugshot appears in top right of google page

@rnchamberlain
Copy link

watching on utube ok

@richardlau
Copy link
Member

Same, am signed in. I'll follow on youtube.

@richardlau
Copy link
Member

Got in, had to removed the end of the url (everything after the ?).

@joshgav
Copy link
Contributor Author

joshgav commented Jan 19, 2017

Sorry @rnchamberlain @richardlau, glad you were able to get in eventually.

@richardlau

had to remove the end of the url (everything after the ?)

<sigh> a couple meetings ago I lopped off the query string (after the ?) and it broke people. Thanks for the tip though, now we know something to try in the future :)

Will get the notes into a PR soon. Thanks everyone!

@joshgav
Copy link
Contributor Author

joshgav commented Jan 20, 2017

Thanks @AndreasMadsen for the update on async_hooks, including that in the notes for reference.

@joshgav
Copy link
Contributor Author

joshgav commented Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants