Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions of sqlite and swc on the dist.json #3847

Open
ovflowd opened this issue Jul 30, 2024 · 4 comments
Open

Add versions of sqlite and swc on the dist.json #3847

ovflowd opened this issue Jul 30, 2024 · 4 comments

Comments

@ovflowd
Copy link
Member

ovflowd commented Jul 30, 2024

Opening an issue to have the versions of sqlite and swc bundled with Node.js to be defined within the dist.json so that the Website can grab that metadata and add this information on the Downloads page.

Also, @marco-ippolito, do you believe it possible to infer the typescript compiler version from the src/wasm-typescript version (?), or does that package not rely on the typescript binary itself?

cc @nodejs/build

@marco-ippolito
Copy link
Member

the typescript version is documented here: https://github.com/nodejs/amaro?tab=readme-ov-file#typescript-version, its currently extracted from the readme of swc

@ovflowd
Copy link
Member Author

ovflowd commented Jul 30, 2024

the typescript version is documented here: nodejs/amaro#typescript-version, its currently extracted from the readme of swc

Is there any update here, manual? (i.e. the version is the same across the board, and only a manual update by a collaborator would change the version?) Thanks for the info, 🤦 to me for not looking it there 😅

@richardlau
Copy link
Member

There is no dist.json 🙂.

The tool that generates index.json and index.tab is https://github.com/nodejs/nodejs-dist-indexer. That works based on GitHub tags, e.g. when indexing Node.js 22.5.1 it will read from GitHub the source at tag v22.5.1. When modifying the tool it needs to be able to cope with the information being missing (e.g. sqlite not present on older releases).

@ovflowd
Copy link
Member Author

ovflowd commented Aug 5, 2024

There is no dist.json 🙂.

Sorry it was a typo, I meant dist/index.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants