Skip to content

Commit

Permalink
Allow admins to remove nodes via ui
Browse files Browse the repository at this point in the history
  • Loading branch information
knolleary committed Jul 20, 2024
1 parent 8dae950 commit c75a166
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 0 deletions.
28 changes: 28 additions & 0 deletions routes/nodes.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ var ratings = require("../lib/ratings");
var templates = require("../lib/templates");
var events = require("../lib/events");
var collections = require("../lib/collections");
var settings = require("../config");

var app = express();

Expand Down Expand Up @@ -53,6 +54,8 @@ function getNode(id, scope, collection, req,res) {
}
npmNodes.get(id).then(function(node) {
node.sessionuser = req.session.user;
node.isAdmin = node.sessionuser && (settings.admins.indexOf(req.session.user.login) != -1);
node.Admins = settings.admins
node.csrfToken = req.csrfToken();
node.pageTitle = req.params.id+" (node)";

Expand Down Expand Up @@ -305,6 +308,31 @@ app.get("/add/node",appUtils.csrfProtection(),function(req,res) {
res.send(mustache.render(templates.addNode,context,templates.partials));
});

app.delete("/node/:scope(@[^\\/]{1,})?/:id([^@][^\\/]{1,})", appUtils.csrfProtection(),function(req,res) {
var id = req.params.id;
if (req.params.scope) {
id = req.params.scope+"/"+id;
}
const isValid = validatePackage(id)
if (!isValid.validForNewPackages && !isValid.validForOldPackages) {
res.status(404).send()
return
}
if (!req.session.user || settings.admins.indexOf(req.session.user.login) === -1) {
res.status(404).send()
return
}
npmNodes.remove(id).then(() => {
res.writeHead(303, {
Location: "/"
});
res.end();
}).catch(err => {
res.status(400).send();
})
});


app.post("/add/node",appUtils.csrfProtection(),function(req,res) {
var context = {};
context.sessionuser = req.session.user;
Expand Down
32 changes: 32 additions & 0 deletions template/node.html
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ <h4>Actions</h4>
<button id="refresh-button" type="button" class="user-profile-action" style="background: none; color: #aa6767"><span id="refresh-node-label">check for update</span><img id="refresh-node-loader" class="loader" src="/images/loader.gif" /></button>
<div id="refresh-node-error" class="dialog-warning" style="position:relative"></div>
</form>
{{#isAdmin}}
<button id="remove-button" type="submit" class="user-profile-action" style="background: none; color: #aa6767"><span id="remove-node-label">remove from library</span><img id="remove-node-loader" class="loader" src="/images/loader.gif" /></button>
<div id="remove-node-error" class="dialog-warning" style="position:relative"></div>
{{/isAdmin}}
</div>
{{/sessionuser}}
</div>
Expand Down Expand Up @@ -167,6 +171,34 @@ <h4>Report this module</h4>
});
});

var removeSubmitted = false;
$('#remove-button').click(function(e) {
if (confirm('Are you sure you want to remove this module?')) {
e.preventDefault();
if (refreshSubmitted) {
return;
}
removeSubmitted = true;
$("#remove-node-error").hide();
$("#remove-node-label").hide();
$("#remove-button").addClass("submitted");
$("#remove-node-loader").show();
$.ajax({
url: window.location.pathname + '?_csrf={{csrfToken}}',
type: 'DELETE',
success: function(data) {
window.location = '/';
}
}).fail(function(err) {
removeSubmitted = false;
console.log("ERROR",err);
$("#remove-button").removeClass("submitted");
$("#remove-node-loader").hide();
$("#remove-node-label").show();
$("#remove-node-error").text(err.responseText).show();
});
}
});
});

</script>
Expand Down

0 comments on commit c75a166

Please sign in to comment.