Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to generate session id #6

Open
amitguptagwl opened this issue Oct 5, 2018 · 1 comment
Open

Add an option to generate session id #6

amitguptagwl opened this issue Oct 5, 2018 · 1 comment
Labels
first-timers-only This issue is suitable for first timers. However, can be picked by any contributors good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amitguptagwl
Copy link
Member

Currently, we use hyperid npm package to generate session id, which appends a counter to previously generated session-id. It might give a chance to hacker to guess next/previous session-id.
@amitguptagwl amitguptagwl added help wanted Extra attention is needed good first issue Good for newcomers first-timers-only This issue is suitable for first timers. However, can be picked by any contributors labels Oct 5, 2018
@rcbat73
Copy link

rcbat73 commented Sep 6, 2019

Hi, what about changing to this dependency: https://www.npmjs.com/package/uniqid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only This issue is suitable for first timers. However, can be picked by any contributors good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amitguptagwl @rcbat73