Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/add extraction module for more generic CSV parsing #4

Open
zachsa opened this issue Aug 14, 2018 · 1 comment
Open

Update/add extraction module for more generic CSV parsing #4

zachsa opened this issue Aug 14, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@zachsa
Copy link
Member

zachsa commented Aug 14, 2018

Currently the batched line extraction has the potential to break CSV rows where such a row contains unescaped newline chars.

But this is allowed according to the the RFC 4180 specification. Either the current parser needs to ignore newline markers if they appear within a quoted field (CSV) or a different line extraction needs to be made available.

If CSVs are known NOT to contain newline markers, then the batch extraction as it currently exists can still be used for parsing CSVs via batches

@zachsa zachsa added the bug Something isn't working label Aug 14, 2018
@zachsa zachsa self-assigned this Aug 14, 2018
@zachsa
Copy link
Member Author

zachsa commented Aug 14, 2018

Also need to check that the current extraction does respect escaped newline chars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant