@@ -31,12 +31,14 @@ import (
3131)
3232
3333type ReplayCmd struct {
34- client * sdk.Client
35- from flags.TimeValue
36- configPaths []string
37- sloName string
38- project string
39- deleteAll bool
34+ client * sdk.Client
35+ from TimeValue
36+ from flags.TimeValue
37+ configPaths []string
38+ sloName string
39+ project string
40+ deleteAll bool
41+ playlistsAvailable bool
4042}
4143
4244//go:embed replay_example.sh
@@ -79,6 +81,7 @@ func (r *ReplayCmd) Run(cmd *cobra.Command) error {
7981 if r .client .Config .Project == "*" {
8082 return errProjectWildcardIsNotAllowed
8183 }
84+ r .arePlaylistEnabled (cmd .Context ())
8285 replays , err := r .prepareConfigs ()
8386 if err != nil {
8487 return err
@@ -92,9 +95,7 @@ func (r *ReplayCmd) RunReplays(cmd *cobra.Command, replays []ReplayConfig) (fail
9295 return 0 , err
9396 }
9497
95- arePlaylistEnabled := r .arePlaylistEnabled (cmd .Context ())
96-
97- if arePlaylistEnabled {
98+ if r .playlistsAvailable {
9899 cmd .Println (colorstring .Color ("[yellow]- Your organization has access to Replay queues!" ))
99100 cmd .Println (colorstring .Color ("[yellow]- To learn more about Replay queues, follow this link: " +
100101 "https://docs.nobl9.com/replay-canary/ [reset]" ))
@@ -107,7 +108,7 @@ func (r *ReplayCmd) RunReplays(cmd *cobra.Command, replays []ReplayConfig) (fail
107108 i + 1 , len (replays ), replay .SLO , replay .Project ,
108109 replay .From .Format (flags .TimeLayout ), time .Now ().In (replay .From .Location ()).Format (flags .TimeLayout ))))
109110
110- if arePlaylistEnabled {
111+ if r . playlistsAvailable {
111112 cmd .Println ("Replay is added to the queue..." )
112113 err = r .runReplay (cmd .Context (), replay )
113114
@@ -137,7 +138,12 @@ func (r *ReplayCmd) RunReplays(cmd *cobra.Command, replays []ReplayConfig) (fail
137138 return len (failedIndexes ), nil
138139}
139140
140- func (r * ReplayCmd ) arePlaylistEnabled (ctx context.Context ) bool {
141+ type PlaylistConfiguration struct {
142+ EnabledPlaylists bool `json:"enabledPlaylists"`
143+ }
144+
145+ func (r * ReplayCmd ) arePlaylistEnabled (ctx context.Context ) {
146+ r .playlistsAvailable = true
141147 data , _ , err := r .doRequest (
142148 ctx ,
143149 http .MethodGet ,
@@ -146,17 +152,13 @@ func (r *ReplayCmd) arePlaylistEnabled(ctx context.Context) bool {
146152 nil ,
147153 nil )
148154 if err != nil {
149- return true
155+ fmt . Printf ( "error checking playlist availability: %v \n " , err )
150156 }
151157 var pc PlaylistConfiguration
152158 if err = json .Unmarshal (data , & pc ); err != nil {
153- return true
159+ fmt . Printf ( "error unmarshalling playlist configuration: %v \n " , err )
154160 }
155- return pc .EnabledPlaylists
156- }
157-
158- type PlaylistConfiguration struct {
159- EnabledPlaylists bool `json:"enabledPlaylists"`
161+ r .playlistsAvailable = pc .EnabledPlaylists
160162}
161163
162164type ReplayConfig struct {
@@ -325,16 +327,28 @@ outer:
325327 }
326328
327329 // Check Replay availability.
330+ if err := r .checkReplayAvailability (ctx , replays ); err != nil {
331+ return err
332+ }
333+
334+ return nil
335+ }
336+
337+ func (r * ReplayCmd ) checkReplayAvailability (ctx context.Context , replays []ReplayConfig ) error {
328338 notAvailable := make ([]string , 0 )
329339 mu := sync.Mutex {}
330340 eg , ctx := errgroup .WithContext (ctx )
331341 eg .SetLimit (10 )
342+
332343 for i := range replays {
333344 eg .Go (func () error {
334345 c := replays [i ]
335346 timeNow := time .Now ()
336347 tt := c .ToReplay (timeNow )
337- offset := i * int (averageReplayDuration .Minutes ())
348+ offset := 0
349+ if ! r .playlistsAvailable {
350+ offset = i * int (averageReplayDuration .Minutes ())
351+ }
338352 expectedDuration := offset + tt .Duration .Value
339353 av , err := r .getReplayAvailability (ctx , c , tt .Duration .Unit , expectedDuration )
340354 if err != nil {
@@ -343,6 +357,7 @@ outer:
343357 }
344358 if ! av .Available {
345359 mu .Lock ()
360+ defer mu .Unlock ()
346361 notAvailable = append (notAvailable ,
347362 fmt .Sprintf ("['%s' SLO in '%s' Project] %s" ,
348363 c .SLO , c .Project , r .replayUnavailabilityReasonExplanation (
@@ -351,18 +366,20 @@ outer:
351366 time .Duration (expectedDuration )* time .Minute ,
352367 time .Duration (offset )* time .Minute ,
353368 timeNow )))
354- mu .Unlock ()
355369 }
356370 return nil
357371 })
358372 }
359- if err = eg .Wait (); err != nil {
373+
374+ if err := eg .Wait (); err != nil {
360375 return err
361376 }
377+
362378 if len (notAvailable ) > 0 {
363379 return errors .Errorf ("The following SLOs are not available for Replay: \n - %s" ,
364380 strings .Join (notAvailable , "\n - " ))
365381 }
382+
366383 return nil
367384}
368385
@@ -522,7 +539,7 @@ func (r *ReplayCmd) replayUnavailabilityReasonExplanation(
522539 " + %dm (start offset to ensure Replay covers the desired time window) %s." +
523540 " Edit the Data Source and run Replay once again." ,
524541 replay .metricSource .Name , replay .metricSource .Project , expectedDuration .String (),
525- timeNow .Format (flags .TimeLayout ), r . from .Format (flags .TimeLayout ), startOffsetMinutes , offsetNotice )
542+ timeNow .Format (flags .TimeLayout ), replay . From .Format (flags .TimeLayout ), startOffsetMinutes , offsetNotice )
526543 case sdkModels .ReplayConcurrentReplayRunsLimitExhausted :
527544 return "You've exceeded the limit of concurrent Replay runs. Wait until the current Replay(s) are done."
528545 case sdkModels .ReplayUnknownAgentVersion :
0 commit comments