Skip to content

Commit 4627bc1

Browse files
committed
correct labels setting
1 parent 59fbe90 commit 4627bc1

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

internal/get.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,9 @@ func (g *GetCmd) getObjects(ctx context.Context, args []string, kind manifest.Ki
358358
return nil, errors.New("'sloctl get alerts' does not support Project filtering," +
359359
" explicitly pass '-A' flag to fetch all Alerts.")
360360
}
361-
query := url.Values{
362-
objectsV1.QueryKeyName: args,
363-
objectsV1.QueryKeyLabels: parseFilterLabel(g.labels),
361+
query := url.Values{objectsV1.QueryKeyName: args}
362+
if len(g.labels) > 0 {
363+
query.Set(objectsV1.QueryKeyLabels, parseFilterLabel(g.labels))
364364
}
365365
header := http.Header{sdk.HeaderProject: []string{g.client.Config.Project}}
366366
objects, err := g.client.Objects().V1().Get(ctx, kind, header, query)
@@ -379,7 +379,7 @@ func (g *GetCmd) getObjects(ctx context.Context, args []string, kind manifest.Ki
379379
return objects, nil
380380
}
381381

382-
func parseFilterLabel(filterLabels []string) []string {
382+
func parseFilterLabel(filterLabels []string) string {
383383
labels := make(v1alpha.Labels)
384384
for _, filterLabel := range filterLabels {
385385
filteredLabels := strings.Split(filterLabel, ",")
@@ -404,7 +404,7 @@ func parseFilterLabel(filterLabels []string) []string {
404404
strLabels = append(strLabels, key)
405405
}
406406
}
407-
return strLabels
407+
return strings.Join(strLabels, ",")
408408
}
409409

410410
func (g *GetCmd) printObjects(objects interface{}) error {

0 commit comments

Comments
 (0)