Skip to content

Commit 318e186

Browse files
authored
fix: Unquote ldflags in Release workflow (#41)
## Motivation `LDFLAGS` Docker argument should not be quoted since this causes: ``` invalid value "'-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=v0.0.98'" for flag -ldflags: parameter may not start with quote character ' ```
1 parent 2f2b4ba commit 318e186

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ jobs:
5151
platforms: linux/amd64, linux/arm64
5252
tags: ${{ steps.meta.outputs.tags }}
5353
labels: ${{ steps.meta.outputs.labels }}
54-
build-args: LDFLAGS='-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}'
54+
build-args: LDFLAGS=-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}

0 commit comments

Comments
 (0)