Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oink and serving assets #25

Open
nathany opened this issue Feb 7, 2013 · 4 comments
Open

Oink and serving assets #25

nathany opened this issue Feb 7, 2013 · 4 comments

Comments

@nathany
Copy link

nathany commented Feb 7, 2013

Would it be possible to filter out oink logging when Rails is serving assets (in development)?

It currently spams my logs like this (asset logging itself is being silenced, otherwise those requests would show up):

Feb 07 12:36:18 zephyr rails[2941]: Memory usage: 2658288 | PID: 2941
Feb 07 12:36:18 zephyr rails[2941]: Oink Log Entry Complete
Feb 07 12:36:18 zephyr rails[2941]: Memory usage: 2658288 | PID: 2941
Feb 07 12:36:18 zephyr rails[2941]: Oink Log Entry Complete
Feb 07 12:36:18 zephyr rails[2941]: Memory usage: 2658288 | PID: 2941
Feb 07 12:36:18 zephyr rails[2941]: Oink Log Entry Complete
Feb 07 12:36:18 zephyr rails[2941]: Memory usage: 2658288 | PID: 2941
...
@noahd1
Copy link
Owner

noahd1 commented Feb 15, 2013

Since Oink is executed in Rack Middleware, an approach like this might be a good way to go:

http://icelab.com.au/articles/wrapping-rack-middleware-to-exclude-certain-urls-for-rails-streaming-responses/

Happy to accept a patch that works similarly to this for Oink's middleware.

@KieranP
Copy link

KieranP commented Oct 8, 2013

Any progress with this?

@noahd1
Copy link
Owner

noahd1 commented Oct 9, 2013

Seems like this is basically a development-only kind of issue. Are you making use of Oink in development? If not would just suggest turning oink off entirely in development mode. Otherwise, not sure -- you could wrap the oink middleware in your own to exclude assets.

@nathany
Copy link
Author

nathany commented Oct 9, 2013

Just fyi, we're no longer using Oink in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants