Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing open ended quote at the end of the file #13

Open
gadfort opened this issue Jan 22, 2024 · 1 comment
Open

Missing open ended quote at the end of the file #13

gadfort opened this issue Jan 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gadfort
Copy link

gadfort commented Jan 22, 2024

The follow tcl command doesn't raise any issues with tclint, but it has an open ended quote and a variable for expansion in {}

test_cmd \
    -arg0 {$param0} \
    -arg1 $param1" \
    {*}$args_n

should be:

test_cmd \
    -arg0 $param0 \
    -arg1 $param1 \
    {*}$args_n
@nmoroze
Copy link
Owner

nmoroze commented Jan 24, 2024

Thanks for sending the test case! This is interesting, the quote thing is not actually a bug since it's legal Tcl to have an unmatched quote as long as it doesn't start a word (e.g. puts foo" is legal but puts "foo is not). However, both these things could probably be identified as a likely bug and trigger a linter error/warning, so I'll think about adding some checks for these cases.

@nmoroze nmoroze added the enhancement New feature or request label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants