Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Heading #283

Open
11 of 13 tasks
AlineNap opened this issue Oct 7, 2024 · 0 comments
Open
11 of 13 tasks

Pre Heading #283

AlineNap opened this issue Oct 7, 2024 · 0 comments
Assignees
@MMeijerink
Labels
new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@AlineNap
Copy link
Contributor

AlineNap commented Oct 7, 2024 •
edited by MMeijerink
Loading

Omschrijving

Een ondersteunende tekst die boven een kop staat.

Deze issue tegelijkertijd oppakken met de #282 issue. Component in Storybook ook onder de HeadingGroup stories zetten.

Definition of ready

  • Code check op community component gedaan door lux devs
  • Stijling check op community component gedaan door Aline
  • Plan voor missende features of bugs van het community component beschreven in het ticket
  • Component tokens zijn beschikbaar
  • Ticket doorgenomen met Vlad & Mark

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Links
@AlineNap AlineNap mentioned this issue Oct 7, 2024
Merged
1 task
@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 9, 2024
AlineNap added a commit that referenced this issue Oct 14, 2024
@AlineNap
feat(design tokens): Tokens voor heading group (#284)
9926fb8 
# Contents

Nieuwe tokens: component utrecht pre heading

Voor de tickets #282 en
#283

## Checklist

<!-- Surround an item with double tildes `~~` to indicate that it does
not apply to this PR -->

- ~~[ ] New features/components and bugfixes are covered by tests~~
- [x] Changesets are created
- ~~[ ] Definition of Done is checked~~

---------

Co-authored-by: Jaap-Hein Wester <[email protected]>
@MMeijerink MMeijerink self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMeijerink MMeijerink

Labels
new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Lux React Components
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MrSkippy @MMeijerink @AlineNap