Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some 釋義補充 in 廣韻.csv #7

Closed
wants to merge 1 commit into from

Conversation

FelisNivalis
Copy link

有些釋義補充似乎抄岔了

@syimyuzya
Copy link
Member

Don't edit 廣韻.csv directly.

That file is built from the source files with a script , any changes will be overwritten (so to avoid implicit differences between versions of data, which often makes maintaince difficult, as we had done several times before).

If you want to make fixes to the data, you should incorporate them into the build process, either in a source file or in the build script.

As for the incorrect 釋義補充 data, we are aware of this problem, and are trying to bring up a systematic solution. Ideas are welcome!

@FelisNivalis
Copy link
Author

Thanks for the clarification. I'll close the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants